Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP functioning resolved alerts #1114

Closed
wants to merge 2 commits into from
Closed

Conversation

ofek1weiss
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Aug 24, 2023

ELE-1624 Resolved alert PoC

Definition of done:

  • Extend current flow to support resolved alert
  • See different design options here -- >
    • https://excalidraw.com/#room=e31fa927c783ff49c7da,NdXy9r_msYK_VIpreQGdzA
    • We discussed two main options -
      • Use partition by test unique id to get the previous state per result and send alert on changes (failure / resolved)
      • Create a new state object called DataTest that will contain the last status and then update a different alerts / issues table based on this status change
  • "Reolved" alert appears in Slack if tests failed and then passed

@ofek1weiss ofek1weiss marked this pull request as draft August 24, 2023 11:45
@github-actions
Copy link
Contributor

👋 @ofek1weiss
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@haritamar haritamar closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants