fix(components): [time-picker] input elements with default id in range #16808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @xuyimingwork, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @xuyimingwork, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
xuyimingwork
force-pushed
the
fix_time-picker-range-miss-input-id
branch
2 times, most recently
from
27f0c2f
to
6c2a104
Compare
|
In previous version, I change input to el-input, with style and some function change, it actually worked. Directly using useFormItemInputId in picker.vue may cause some problem, So, I change to use a component to provide range input id info. |
|
Complete test cases for this |
xuyimingwork
force-pushed
the
fix_time-picker-range-miss-input-id
branch
from
8effe92
to
1bdf495
Compare
|
🧪 Playground Preview: https://element-plus.run/?pr=16808 |
fix time-picker type range input elements without default id value closed element-plus#16802
add input id check for time-picker in range adjust non range test cases to right place closed element-plus#16802
xuyimingwork
force-pushed
the
fix_time-picker-range-miss-input-id
branch
from
1bdf495
to
b758d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix time-picker type range input elements without default id value
closed #16802
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.