Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): non-null assertion component name #16804

Merged
merged 2 commits into from May 15, 2024
Merged

fix(types): non-null assertion component name #16804

merged 2 commits into from May 15, 2024

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 10, 2024 •
edited

screenshots

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 10, 2024
@warmthsea
Copy link
Contributor Author

https://github.com/vuejs/core/blob/b2b5f57c2c945edd0eebc1b545ec1b7568e51484/packages/runtime-core/src/componentOptions.ts#L131C3-L131C16

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16804
Please comment the example via this playground if needed.

@btea btea changed the title fix(types): add install component name sure fix(types): non-null assertion component name May 10, 2024
@btea btea requested a review from kooriookami May 10, 2024 12:21
@plainheart plainheart merged commit e35f403 into element-plus:dev May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@plainheart plainheart plainheart approved these changes

@kooriookami kooriookami Awaiting requested review from kooriookami

Assignees

@warmthsea warmthsea

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@warmthsea @btea @plainheart