Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add border-radius for el-loading root element #16751

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

VisualYuki
Copy link
Contributor

@VisualYuki VisualYuki commented May 5, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @VisualYuki, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented May 5, 2024

Hello @VisualYuki, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented May 5, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 5, 2024
@VisualYuki
Copy link
Contributor Author

VisualYuki commented May 5, 2024

playground example.
short example for my commit, uncomment 35-37 lines.
https://element-plus.run/#eyJzcmMvQXBwLnZ1ZSI6IjxzY3JpcHQgc2V0dXAgbGFuZz1cInRzXCI+XG5pbXBvcnQgeyByZWYsIHZlcnNpb24gYXMgdnVlVmVyc2lvbiB9IGZyb20gJ3Z1ZSdcbmltcG9ydCB7IHZlcnNpb24gYXMgZXBWZXJzaW9uIH0gZnJvbSAnZWxlbWVudC1wbHVzJ1xuaW1wb3J0IHsgRWxlbWVudFBsdXMgfSBmcm9tICdAZWxlbWVudC1wbHVzL2ljb25zLXZ1ZSdcblxuY29uc3QgbXNnID0gcmVmKCdIZWxsbyBXb3JsZCEnKVxuPC9zY3JpcHQ+XG5cbjx0ZW1wbGF0ZT5cbiAgPGgxPnt7IG1zZyB9fTwvaDE+XG4gIDxlbC1pbnB1dCB2LW1vZGVsPVwibXNnXCIgLz5cblxuICA8cD5cbiAgICA8ZWwtaWNvbiBjb2xvcj1cInZhcigtLWVsLWNvbG9yLXByaW1hcnkpXCI+PEVsZW1lbnRQbHVzIC8+PC9lbC1pY29uPlxuICAgIEVsZW1lbnQgUGx1cyB7eyBlcFZlcnNpb24gfX0gKyBWdWUge3sgdnVlVmVyc2lvbiB9fVxuICAgIDxwIGNsYXNzPVwidGFyZ2V0XCIgdi1sb2FkaW5nPVwidHJ1ZVwiPjwvcD5cbiAgPC9wPlxuPC90ZW1wbGF0ZT5cblxuPHN0eWxlPlxuYm9keSB7XG5iYWNrZ3JvdW5kLWNvbG9yOiBncmF5O1xufVxuXG4udGFyZ2V0ICB7XG53aWR0aDogMTAwcHg7XG5oZWlnaHQ6IDEwMHB4O1xuXG5ib3JkZXItcmFkaXVzOiAxMDBweDtcbmJhY2tncm91bmQtY29sb3I6IHJlZDtcblxuXG59XG5cbi8qLmVsLWxvYWRpbmctbWFzayB7XG5ib3JkZXItcmFkaXVzOiAxMDBweDtcbn0qL1xuPC9zdHlsZT5cbiIsImltcG9ydC1tYXAuanNvbiI6IntcbiAgXCJpbXBvcnRzXCI6IHt9XG59IiwidHNjb25maWcuanNvbiI6IntcbiAgXCJjb21waWxlck9wdGlvbnNcIjoge1xuICAgIFwidGFyZ2V0XCI6IFwiRVNOZXh0XCIsXG4gICAgXCJqc3hcIjogXCJwcmVzZXJ2ZVwiLFxuICAgIFwibW9kdWxlXCI6IFwiRVNOZXh0XCIsXG4gICAgXCJtb2R1bGVSZXNvbHV0aW9uXCI6IFwiQnVuZGxlclwiLFxuICAgIFwidHlwZXNcIjogW1wiZWxlbWVudC1wbHVzL2dsb2JhbC5kLnRzXCJdLFxuICAgIFwiYWxsb3dJbXBvcnRpbmdUc0V4dGVuc2lvbnNcIjogdHJ1ZSxcbiAgICBcImFsbG93SnNcIjogdHJ1ZSxcbiAgICBcImNoZWNrSnNcIjogdHJ1ZVxuICB9LFxuICBcInZ1ZUNvbXBpbGVyT3B0aW9uc1wiOiB7XG4gICAgXCJ0YXJnZXRcIjogMy4zXG4gIH1cbn1cbiIsIl9vIjp7fX0=

Copy link

github-actions bot commented May 5, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16751
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented May 7, 2024

Thank you for your contribution! However, it may be more convenient and faster to adjust this requirement by yourself through style adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants