Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): support playground sync theme #16735

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

btea
Copy link
Collaborator

@btea btea commented May 1, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Sync element-plus/element-plus-playground#265

Copy link

github-actions bot commented May 1, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 1, 2024
Copy link

github-actions bot commented May 1, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16735
Please comment the example via this playground if needed.

@btea btea requested a review from kooriookami May 3, 2024 13:52
@kooriookami
Copy link
Member

There's an error in dark mode: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.

@btea
Copy link
Collaborator Author

btea commented May 6, 2024

I created this PR so that if the dark mode is selected when viewing the document, it will also be set to dark mode simultaneously when clicking on playground to jump.

I don’t understand a bit about the error you mentioned in dark mode. 🤔

@kooriookami
Copy link
Member

Demo

@btea
Copy link
Collaborator Author

btea commented May 6, 2024

Thanks for the demo, I understand.

@kooriookami
Copy link
Member

image

Components still be light.

@btea
Copy link
Collaborator Author

btea commented May 6, 2024

This should be a problem on the playground side. The dark mode code corresponding to the PR-generated style code is not loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants