Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select-v2] with teleported="false" dropdown closes abnormally #16714

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(components): [select-v2] with teleported="false" dropdown closes abnormally #16714

wants to merge 1 commit into from
+10 −3

Conversation

GUEThe
Copy link

@GUEThe GUEThe commented Apr 29, 2024 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #16653 [Component] [select-v2] Virtualized select with teleported="false": When you click on the scrollbar, the dropdown automatically closes

@pull-request-triage Pull Request Triage
Copy link

👋 @GUEThe, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @GUEThe, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16714
Please comment the example via this playground if needed.

@GUEThe
Copy link
Author

GUEThe commented May 4, 2024

Preview

@GUEThe GUEThe force-pushed the he/fix/select-v2 branch 4 times, most recently from 6e18697 to c0c6cf0 Compare May 11, 2024 06:25
@GUEThe GUEThe force-pushed the he/fix/select-v2 branch 2 times, most recently from 7d749c5 to 1aec499 Compare May 13, 2024 15:12
@GUEThe
fix(components): [select-v2] with teleported="false" dropdown closes bug
f2aa11c 
Expose listContainerRef, when 'click' event is form listContainerRef and teleported is'false',return
'toggleMenu' function.

closed element-plus#16653
@btea btea changed the title fix(components): [select-v2] with teleported="false" dropdown closes abnormally fix(components): [select-v2] with teleported="false" dropdown closes abnormally May 19, 2024
@iZhangHao1997
Copy link

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@GUEThe GUEThe

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@GUEThe @iZhangHao1997 @btea