Declare C++14 as required for building #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
force-pushed
the
hotfix/cmake-cppstd
branch
from
71f0453
to
44ed2e2
Compare
3 tasks
|
Hello, This looks good to me. I noticed we don't have a CLA for you, would you mind filling out the form? Then we can merge this when the conflicts are resolved. Thanks |
|
@grojo-ea It's done, the CLA is signed and conflicts are solved. Thank you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EASTL uses C++11 and C++14 features like
static_assertandconstexpr, however, there is no assigned standard in CMakeLists.txt, which breaks older compiler like GCC 5. Plus, it provides an non predictable scenario, as may depend on the standard supported by the compiler.It would be much safer by adding the minimal C++ standard required to build EASTL, so people can reproduce their scenario when building EASTL.