Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use event classes in US-SPP parser #6553

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

yujia21
Copy link
Contributor

@yujia21 yujia21 commented Mar 11, 2024

Issue

6011

Description

Use event classes in US-SPP parser

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code tests labels Mar 11, 2024
@VIKTORVAV99 VIKTORVAV99 self-requested a review March 23, 2024 08:16
parsers/US_SPP.py Show resolved Hide resolved
parsers/US_SPP.py Outdated Show resolved Hide resolved
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks for doing this and sorry for the delay in the review!

@VIKTORVAV99 VIKTORVAV99 merged commit eee17de into electricitymaps:master Jun 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants