Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Canary Islands oil emission factors #6497

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

silimotion
Copy link
Contributor

Description

This PR adds better emission factors for the Canary Islands. In a similar fashion to my previous #6406, I've used the ETS emissions data. In this case, I've got the total electricity produced each year from the EM app. I have no reason to think this data isn't accurate, as the there is no estimation in the data, and the results are similar to other emission factors published by REE. I didn't use those because they are aggregated and less accurate.

In islands where there were several power plants, I've added the emissions values, and divided by the total production amount. The mappings are as follows:

  • El Hierro:
    • Llanos Blancos
  • La Palma:
    • Los Guinchos
  • La Gomera:
    • El Palmar
  • Tenerife:
    • Granadilla
    • Candelaria
    • Guía de Isora
    • Arona
  • Gran Canaria:
    • Barranco de Tirajana
    • Jinámar
  • Fuerteventura-Lanzarote:
    • Las Salinas
    • Punta Grande

As a note:

This same process could be used for other Spanish regions, but the historical data available in the app is not valid. In some cases, because there is no data for the ETS years (Ceuta, Melilla). In others because the data was being recorded wrongfully (this was resolved in the parser rewrite) and has not been updated yet. In those cases the data could be updated in the backend, or I could build my own script to download the data.

In Mallorca there are plants with several fuels so the ETS path is useless.

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Feb 20, 2024
@VIKTORVAV99
Copy link
Member

This looks really nice! Will do a final review tomorrow!

As for this:

In others because the data was being recorded wrongfully (this was resolved in the parser rewrite) and has not been updated yet.

If you know the regions that are wrong I can ensure they are updated when the next monthly and yearly aggregation is run (1st of march) (I hope).

@VIKTORVAV99 VIKTORVAV99 requested review from VIKTORVAV99 and a user February 20, 2024 17:32
@VIKTORVAV99 VIKTORVAV99 added the emission factors Issues or PRs related to emission factors label Feb 20, 2024
@silimotion
Copy link
Contributor Author

The ones fixed in the rewrite were Ibiza and Menorca. Formentera mapping was changed so I think it could be rerun or at least edited. I think that in Mallorca there were no changes.

If it is possible it would be nice to also update Cyprus as I've seen some years have big estimation proportions, creating spurious "unknown" production. Also, the oil factors were changed recently but the calculated factors for total production were not updated. I don't know if it is a bug or just that the backend needs more time. Cyprus historical parser did not record capacity so be careful not to overwrite anything.

@VIKTORVAV99
Copy link
Member

A lot of these will change by next month as I have already re-fetched and reprocessed a lot of the data (Cyprus included). But it won't be noticeable until the aggregates update.

@VIKTORVAV99
Copy link
Member

I'll have to take a look at the Spanish islands though, if the mapping was changed completely and the old modes are None now it might not get overwritten properly.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the emission factors themselves are reasonable. But the source link seems to be the same as the one we use for ENTSO-E which don't seem right.

Comment on lines +207 to +208
https://drive.google.com/file/d/15UeUHyhcjVw8fGLc0Zx_HELSx20cw_-e/view?usp=share_link,
https://demanda.ree.es
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the same link as for ENTSO-E, this seems like a misstake? Did you forget to update it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the ETS source and overall methodology for the emission factors is explained in the notebook, I thought it could be helpful. Should I remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source needs to be a link to the actual calculation so they can be verified by anyone at a later date.

It can be a spreadsheet or Jupyter notebook or something similar but it needs to have some sort of reproducibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok... I can make a notebook with the calculations... Where can I upload it though? I assume you would want to have edit access, etc...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://colab.research.google.com would be a good place to upload it, we don't need write access just read access so we can copy it if need be.

@VIKTORVAV99 VIKTORVAV99 marked this pull request as draft March 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emission factors Issues or PRs related to emission factors zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants