refactor: removed arrow from CA-AB parser #6179
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the parser to use `datetime`. Parser functionality has not changed. - add `24` hour handling (midnight next day)
VIKTORVAV99
reviewed
Nov 30, 2023
…ectricitymaps-contrib into 6135-remove-arrow-CA_AB
VIKTORVAV99
reviewed
Dec 12, 2023
Comment on lines
+85
to
+86
| datetime=datetime.strptime(f"{date} {int(hour) - 1}", "%m/%d/%Y %H") | ||
| + timedelta(hours=1), |
There was a problem hiding this comment.
Suggested change
| datetime=datetime.strptime(f"{date} {int(hour) - 1}", "%m/%d/%Y %H") | |
| + timedelta(hours=1), | |
| datetime=datetime.strptime(f"{date} {int(hour) - 1}", "%m/%d/%Y %H").replace(tzinfo=TIMEZONE), | |
| + timedelta(hours=1), |
We need to attach a the timezone as well.
Also are you sure that the value of hour 24 are for 00 the next day and not simply hour 23 but 1 indexed? Otherwise we don't need the timedelta.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: #6135
Description
Upgrade the parser to use
datetime. Parser functionality has not changed.24hour handling (midnight next day)Preview
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.