Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): Move e2e test to 03 group #1202

Merged
merged 1 commit into from May 1, 2024

Conversation

davidmartos96
Copy link
Contributor

Should this test belong to the 03 group?
For the Dart client we are using all the 03.x tests, but we noticed this is the only test that imports the satellite node macros and it's not in the 03 group.

cc @alco

@kevin-dp
Copy link
Contributor

I agree that this belongs to the 03 group as it involves client Satellites. Let's see if @alco agrees

@alco
Copy link
Member

alco commented Apr 30, 2024

Conceptually, it's a sanity checking test, which is what the 01 group is for. I could rewrite it using Elixir client, I'm just not a fan of the split between Elixir and Node clients. There should only be the Node client, IMO, since these are end-to-end tests.

But in practical terms, this test belongs in the 03 group if it matters to have all tests that involve the Node client there.

@davidmartos96
Copy link
Contributor Author

@alco It's a minor thing. I started the discussion mainly for convenience over in the Dart client port, where we use this command to run the e2e. We use the same 03 group Lux logic with a real Dart client.

image

@alco
Copy link
Member

alco commented May 1, 2024

Alright, sounds good. But please use the 03.26 as the prefix in the new name since we have renamed a few e2e tests in the upcoming #1038 PR. We can merge this after that PR has been merged.

@alco
Copy link
Member

alco commented May 1, 2024

Nevermind!

@alco alco merged commit b7dcace into electric-sql:main May 1, 2024
2 checks passed
@davidmartos96 davidmartos96 deleted the move_e2e branch May 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants