Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linearlite with PGlite #1164

Merged
merged 2 commits into from May 2, 2024
Merged

Linearlite with PGlite #1164

merged 2 commits into from May 2, 2024

Conversation

samwillis
Copy link
Contributor

@samwillis samwillis commented Apr 17, 2024

Enables using Linearlite with PGlite or wa-sqlite by setting the ELECTRIC_CLIENT_DB env var to either wa-sqlite or pglite. This can be done in the .env file or any other standard way. It will be embedded into the build so a build will be for one or the other.

To be merged after #1038 with the electric-sql rep either pointing at a canary build or a published version.

Base automatically changed from samwillis/pglite to kevindp/vax-1638-pg-generator April 18, 2024 13:49
@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch 4 times, most recently from 6ddf542 to 4b861d7 Compare April 25, 2024 12:42
@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch 8 times, most recently from 1a23461 to 6e6ea2e Compare April 30, 2024 07:35
@samwillis samwillis force-pushed the samwillis/linearlite-pglite branch 2 times, most recently from 186b574 to 8dedd13 Compare April 30, 2024 13:02
@samwillis samwillis changed the title POC: Linearlite with PGlite Linearlite with PGlite Apr 30, 2024
@samwillis samwillis marked this pull request as ready for review April 30, 2024 13:05
@samwillis samwillis requested a review from msfstef April 30, 2024 13:05
@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch from 83ffb7e to ff6c0c2 Compare April 30, 2024 13:11
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some minor comments, main thing is the added zod dependency violates the requirement for the 3.21.1 version

examples/linearlite/src/electric.tsx Outdated Show resolved Hide resolved
examples/linearlite/src/components/TopFilter.tsx Outdated Show resolved Hide resolved
examples/linearlite/package.json Show resolved Hide resolved
examples/linearlite/src/electric.tsx Show resolved Hide resolved
@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch 2 times, most recently from 8e17eb6 to b4c0952 Compare April 30, 2024 13:52
Base automatically changed from kevindp/vax-1638-pg-generator to main May 2, 2024 15:34
@samwillis samwillis force-pushed the samwillis/linearlite-pglite branch from a3dfe9f to 7ea7561 Compare May 2, 2024 16:00
@samwillis samwillis merged commit 30eb725 into main May 2, 2024
8 checks passed
@samwillis samwillis deleted the samwillis/linearlite-pglite branch May 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants