New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linearlite with PGlite #1164
Merged
Merged
Linearlite with PGlite #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
from
April 17, 2024 16:31
64f5142
to
a0ab51e
Compare
Base automatically changed from
samwillis/pglite
to
kevindp/vax-1638-pg-generator
April 18, 2024 13:49
kevin-dp
force-pushed
the
kevindp/vax-1638-pg-generator
branch
4 times, most recently
from
April 25, 2024 12:42
6ddf542
to
4b861d7
Compare
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
from
April 29, 2024 11:44
a0ab51e
to
3e5a39c
Compare
kevin-dp
force-pushed
the
kevindp/vax-1638-pg-generator
branch
8 times, most recently
from
April 30, 2024 07:35
1a23461
to
6e6ea2e
Compare
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
2 times, most recently
from
April 30, 2024 13:02
186b574
to
8dedd13
Compare
kevin-dp
force-pushed
the
kevindp/vax-1638-pg-generator
branch
from
April 30, 2024 13:11
83ffb7e
to
ff6c0c2
Compare
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
from
April 30, 2024 13:21
8dedd13
to
defe75f
Compare
msfstef
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some minor comments, main thing is the added zod dependency violates the requirement for the 3.21.1 version
kevin-dp
force-pushed
the
kevindp/vax-1638-pg-generator
branch
2 times, most recently
from
April 30, 2024 13:52
8e17eb6
to
b4c0952
Compare
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
from
April 30, 2024 21:36
defe75f
to
45a7017
Compare
samwillis
force-pushed
the
samwillis/linearlite-pglite
branch
from
May 2, 2024 16:00
a3dfe9f
to
7ea7561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables using Linearlite with PGlite or wa-sqlite by setting the
ELECTRIC_CLIENT_DB
env var to eitherwa-sqlite
orpglite
. This can be done in the.env
file or any other standard way. It will be embedded into the build so a build will be for one or the other.To be merged after #1038 with the
electric-sql
rep either pointing at a canary build or a published version.