Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and clarified JWT documentation #1146

Merged
merged 3 commits into from May 6, 2024

Conversation

fooware
Copy link
Contributor

@fooware fooware commented Apr 11, 2024

  • Added a note that AUTH_JWT_NAMESPACE does not affect the validation of the standard claims, like the aud check you enable with AUTH_JWT_AUD.
  • Fixed a typo that said sub was a custom claim.
  • Updated a reference to user_id that did not use the newer sub.
  • Fixed some spelling errors

@fooware
Copy link
Contributor Author

fooware commented May 3, 2024

@alco , this is a simple doc change and has been open for a while now. Feel free to reject it if you don't like it, but otherwise should probably just be merged?

Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fixes and the suggested content changes!

docs/usage/auth/secure.md Outdated Show resolved Hide resolved
docs/usage/auth/secure.md Outdated Show resolved Hide resolved
fooware and others added 2 commits May 6, 2024 09:59
Co-authored-by: Oleksii Sholik <accounts+github@alco.dev>
@alco alco merged commit b2031c4 into electric-sql:main May 6, 2024
6 of 10 checks passed
@alco
Copy link
Member

alco commented May 6, 2024

Thank you!

@fooware fooware deleted the fooware/jwt_doc_updates branch May 6, 2024 13:45
alco added a commit that referenced this pull request May 19, 2024
- Added a note that AUTH_JWT_NAMESPACE does not affect the validation of
the standard claims, like the `aud` check you enable with AUTH_JWT_AUD.
- Updated a reference to `user_id` that did not use the newer `sub`.
- Fixed some spelling errors

---------

Co-authored-by: Oleksii Sholik <accounts+github@alco.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants