feat(electric): Resume client's replication stream from the on-disk WAL window #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
changed the title
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
513ece2
to
29a7a18
Compare
alco
force-pushed
the
alco/vax-1773-resume-clients-from-wal
branch
2 times, most recently
from
1e15da1
to
c1de297
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
2 times, most recently
from
affe5c3
to
f14c8da
Compare
alco
force-pushed
the
alco/vax-1773-resume-clients-from-wal
branch
from
c1de297
to
b901be3
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
f14c8da
to
f00b664
Compare
alco
force-pushed
the
alco/vax-1773-resume-clients-from-wal
branch
from
b901be3
to
8c6e5ef
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
3 times, most recently
from
5b9352a
to
4aaf792
Compare
|
Closing this since it has become evident that the total size of electric transactions contained in the on-disk WAL backlog is unlikely to exceed the size of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to resume the replication stream for clients whose position in the replication stream is outside of the in-memory cached WAL window. This is done by streaming transactions directly from the replication slot. Assuming the slot's start position goes back further than the in-memory cache can fit, this effectively extends the resumable WAL window that the sync service can use before having to ask clients to reset their local state.
This implementation builds on the primitives introduced in #1119.