Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Add custom dashboard tracking event #183659

Conversation

jennypavlova
Copy link
Contributor

@jennypavlova jennypavlova commented May 16, 2024

Closes #182859

Summary

This PR adds a tracking event Asset Dashboard Loaded when the custom dashboard is loaded on the dashboards tab.

So to understand the usage of the filters we want to track:

  • when the page loads with the dashboard tab open
  • If the dashboard filters change or a different dashboard is selected
  • when the dashboard is initially loaded (and the filters applied)
    We don't want to track:
  • If the dashboard is not changed, in case:
    • Edit action is canceled or the same filters are saved
    • the same dashboard is selected
    • switching to a different tab and back to the dashboards tab (showing the same dashboard)

Testing

Go to the asset details flyout/ asset details page and select the dashboards tab

  • Add a dashboard with a filter ( Check tracking )
    image

  • Add a dashboard without a filter ( Check tracking )
    image

  • Switch dashboards ( Check tracking )

  • Edit a dashboard ( Check tracking )

switch.mov
  • Should not track:
not_track.mov

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 16, 2024
@jennypavlova jennypavlova self-assigned this May 16, 2024
@jennypavlova jennypavlova requested a review from a team as a code owner May 16, 2024 15:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 16, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 21, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +356.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5410 +5410
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 105.1KB 105.6KB +508.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jennypavlova jennypavlova merged commit 29ace6d into elastic:main May 21, 2024
22 checks passed
@jennypavlova jennypavlova deleted the 182859-infra-add-dashboard-tracking-event-with-filter-properties branch May 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Add dashboard tracking event with filter properties
6 participants