Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supertest and superagent to latest version #183587

Merged
merged 18 commits into from
May 17, 2024
Merged

Update supertest and superagent to latest version #183587

merged 18 commits into from
May 17, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented May 16, 2024 •
edited

Summary

Related to #7104

Update supertest, superagent, and the corresponding type package, to their latest version.

(of course, types had some signature changes and we're massively using supertest in all our FTR suites so the whole Kibana multiverse has to review it)

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels May 16, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review May 16, 2024 14:45
@pgayvallet pgayvallet requested a review from a team as a code owner May 16, 2024 14:45
jughosta
jughosta approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

ymao1
ymao1 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes LGTM

@jeramysoucy jeramysoucy self-requested a review May 16, 2024 17:46
afharo
afharo approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

walterra
walterra approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML related changes LGTM

dmlemeshko
dmlemeshko approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appex-QA changes LGTM

machadoum
machadoum approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity Analytics changes LGTM!

miltonhultgren
miltonhultgren approved these changes May 17, 2024
View reviewed changes
...t/observability_ai_assistant_api_integration/common/observability_ai_assistant_api_client.ts Outdated
@@ -70,17 +70,62 @@ type WithoutPromise<T extends Promise<any>> = Subtract<T, Promise<any>>;
// end(one:string)
// end(one:string, two:string)
// }
// would lose the first signature. This keeps up to four signatures.
// would lose the first signature. This keeps up to height signatures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
// would lose the first signature. This keeps up to height signatures.
// would lose the first signature. This keeps up to eight signatures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 thanks

thomheymann
thomheymann approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM

wayneseymour
wayneseymour requested changes May 17, 2024
View reviewed changes
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really I'm asking selfishly as I'm building off of this pr, and this change in particular, with others that are coming soon.

What say you Pierre?! :)

x-pack/test_serverless/shared/services/bsearch_secure.ts
@@ -25,7 +25,7 @@ const parseBfetchResponse = (resp: request.Response): Array<Record<string, any>>
};

interface SendOptions {
supertestWithoutAuth: SuperTest.SuperTest<SuperTest.Test>;
supertestWithoutAuth: SuperTest.Agent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgayvallet Hey man, should this type differ from the regular super test, with auth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, the type is the same for the 2 instances, supertest and supertestWithoutAuth are just two instances of the same type/interface (until you changed that in your PR, but I don't think you did?)

jennypavlova
jennypavlova approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM

@jeramysoucy jeramysoucy removed their request for review May 17, 2024 09:58
@pgayvallet pgayvallet enabled auto-merge (squash) May 17, 2024 10:02
wayneseymour
wayneseymour approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dgieselaar
dgieselaar reviewed May 17, 2024
View reviewed changes
...t/observability_ai_assistant_api_integration/common/observability_ai_assistant_api_client.ts
@@ -70,17 +70,62 @@ type WithoutPromise<T extends Promise<any>> = Subtract<T, Promise<any>>;
// end(one:string)
// end(one:string, two:string)
// }
// would lose the first signature. This keeps up to four signatures.
// would lose the first signature. This keeps up to eight signatures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorgeous

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, right?

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 17, 2024 •
edited

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5405 +5405
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 148eeec into elastic:main May 17, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

@vitaliidm vitaliidm vitaliidm approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@ymao1 ymao1 ymao1 approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@cnasikas cnasikas cnasikas approved these changes

@kpollich kpollich kpollich approved these changes

@afharo afharo afharo approved these changes

@thomheymann thomheymann thomheymann approved these changes

@wayneseymour wayneseymour wayneseymour approved these changes

@seanrathier seanrathier seanrathier approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@machadoum machadoum machadoum approved these changes

@jughosta jughosta jughosta approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team Team:Obs AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet