[Security Solution] [Attack discovery] Overrides default Attack discovery timeouts #183575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scovery timeouts ### Summary This PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes. In LangSmith, the retry looks like the following _before_ screenshot: #### Before  _Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes_ After the fix, a single pair for runs > 2 minutes are observed in LangSmith: #### After  _Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes_ ### Details This PR overrides the following default timeouts: 1) The attack discovery route's `idleSocket` socket timeout in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts` 2) The connector timeout (also in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`) 3) The chain timeout in `x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.ts` with the following defaults: ```typescript const ROUTE_HANDLER_TIMEOUT = 10 * 60 * 1000; // 10 * 60 seconds = 10 minutes const LANG_CHAIN_TIMEOUT = ROUTE_HANDLER_TIMEOUT - 10_000; // 9 minutes 50 seconds const CONNECTOR_TIMEOUT = LANG_CHAIN_TIMEOUT - 10_000; // 9 minutes 40 seconds ``` ### Desk testing 1) Verify there are ~ 100 open alerts in the last 24 hours in your testing environment 2) Navigate to Security > Attack discovery 3) Select an Azure / OpenAI connector 4) Click Generate **Expected results** - LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM responds (with the final answer) in less than 2 minutes - LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by the `before` / `after` screenshots in the description above
andrew-goldstein
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
…very timeouts (elastic#183575) ## [Security Solution] [Attack discovery] Overrides default Attack discovery timeouts ### Summary This PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes. In LangSmith, the retry looks like the following _before_ screenshot: #### Before  _Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes_ After the fix, a single pair for runs > 2 minutes are observed in LangSmith: #### After  _Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes_ ### Details This PR overrides the following default timeouts: 1) The attack discovery route's `idleSocket` socket timeout in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts` 2) The connector timeout (also in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`) 3) The chain timeout in `x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.ts` with the following defaults: ```typescript const ROUTE_HANDLER_TIMEOUT = 10 * 60 * 1000; // 10 * 60 seconds = 10 minutes const LANG_CHAIN_TIMEOUT = ROUTE_HANDLER_TIMEOUT - 10_000; // 9 minutes 50 seconds const CONNECTOR_TIMEOUT = LANG_CHAIN_TIMEOUT - 10_000; // 9 minutes 40 seconds ``` ### Desk testing 1) Verify there are ~ 100 open alerts in the last 24 hours in your testing environment 2) Navigate to Security > Attack discovery 3) Select an Azure / OpenAI connector 4) Click Generate **Expected results** - LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM responds (with the final answer) in less than 2 minutes - LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by the `before` / `after` screenshots in the description above (cherry picked from commit 1c96c31)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
…k discovery timeouts (#183575) (#183581) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution] [Attack discovery] Overrides default Attack discovery timeouts (#183575)](#183575) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2024-05-16T00:26:20Z","message":"[Security Solution] [Attack discovery] Overrides default Attack discovery timeouts (#183575)\n\n## [Security Solution] [Attack discovery] Overrides default Attack discovery timeouts\r\n\r\n### Summary\r\n\r\nThis PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes.\r\n\r\nIn LangSmith, the retry looks like the following _before_ screenshot:\r\n\r\n#### Before\r\n\r\n\r\n\r\n_Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes_\r\n\r\nAfter the fix, a single pair for runs > 2 minutes are observed in LangSmith:\r\n\r\n#### After\r\n\r\n\r\n\r\n_Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes_\r\n\r\n### Details\r\n\r\nThis PR overrides the following default timeouts:\r\n\r\n1) The attack discovery route's `idleSocket` socket timeout in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`\r\n\r\n2) The connector timeout (also in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`)\r\n\r\n3) The chain timeout in `x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.ts`\r\n\r\nwith the following defaults:\r\n\r\n```typescript\r\nconst ROUTE_HANDLER_TIMEOUT = 10 * 60 * 1000; // 10 * 60 seconds = 10 minutes\r\nconst LANG_CHAIN_TIMEOUT = ROUTE_HANDLER_TIMEOUT - 10_000; // 9 minutes 50 seconds\r\nconst CONNECTOR_TIMEOUT = LANG_CHAIN_TIMEOUT - 10_000; // 9 minutes 40 seconds\r\n```\r\n\r\n### Desk testing\r\n\r\n1) Verify there are ~ 100 open alerts in the last 24 hours in your testing environment\r\n\r\n2) Navigate to Security > Attack discovery\r\n\r\n3) Select an Azure / OpenAI connector\r\n\r\n4) Click Generate\r\n\r\n**Expected results**\r\n\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM responds (with the final answer) in less than 2 minutes\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by the `before` / `after` screenshots in the description above","sha":"1c96c31aee5dc3b9b4f21639cd21e81c200bf76d","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team: SecuritySolution","Team:Security Generative AI","v8.14.0","v8.15.0","Feature:Attack Discovery"],"title":"[Security Solution] [Attack discovery] Overrides default Attack discovery timeouts","number":183575,"url":"#183575 Solution] [Attack discovery] Overrides default Attack discovery timeouts (#183575)\n\n## [Security Solution] [Attack discovery] Overrides default Attack discovery timeouts\r\n\r\n### Summary\r\n\r\nThis PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes.\r\n\r\nIn LangSmith, the retry looks like the following _before_ screenshot:\r\n\r\n#### Before\r\n\r\n\r\n\r\n_Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes_\r\n\r\nAfter the fix, a single pair for runs > 2 minutes are observed in LangSmith:\r\n\r\n#### After\r\n\r\n\r\n\r\n_Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes_\r\n\r\n### Details\r\n\r\nThis PR overrides the following default timeouts:\r\n\r\n1) The attack discovery route's `idleSocket` socket timeout in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`\r\n\r\n2) The connector timeout (also in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`)\r\n\r\n3) The chain timeout in `x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.ts`\r\n\r\nwith the following defaults:\r\n\r\n```typescript\r\nconst ROUTE_HANDLER_TIMEOUT = 10 * 60 * 1000; // 10 * 60 seconds = 10 minutes\r\nconst LANG_CHAIN_TIMEOUT = ROUTE_HANDLER_TIMEOUT - 10_000; // 9 minutes 50 seconds\r\nconst CONNECTOR_TIMEOUT = LANG_CHAIN_TIMEOUT - 10_000; // 9 minutes 40 seconds\r\n```\r\n\r\n### Desk testing\r\n\r\n1) Verify there are ~ 100 open alerts in the last 24 hours in your testing environment\r\n\r\n2) Navigate to Security > Attack discovery\r\n\r\n3) Select an Azure / OpenAI connector\r\n\r\n4) Click Generate\r\n\r\n**Expected results**\r\n\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM responds (with the final answer) in less than 2 minutes\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by the `before` / `after` screenshots in the description above","sha":"1c96c31aee5dc3b9b4f21639cd21e81c200bf76d"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183575 Solution] [Attack discovery] Overrides default Attack discovery timeouts (#183575)\n\n## [Security Solution] [Attack discovery] Overrides default Attack discovery timeouts\r\n\r\n### Summary\r\n\r\nThis PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes.\r\n\r\nIn LangSmith, the retry looks like the following _before_ screenshot:\r\n\r\n#### Before\r\n\r\n\r\n\r\n_Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes_\r\n\r\nAfter the fix, a single pair for runs > 2 minutes are observed in LangSmith:\r\n\r\n#### After\r\n\r\n\r\n\r\n_Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes_\r\n\r\n### Details\r\n\r\nThis PR overrides the following default timeouts:\r\n\r\n1) The attack discovery route's `idleSocket` socket timeout in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`\r\n\r\n2) The connector timeout (also in `x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts`)\r\n\r\n3) The chain timeout in `x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.ts`\r\n\r\nwith the following defaults:\r\n\r\n```typescript\r\nconst ROUTE_HANDLER_TIMEOUT = 10 * 60 * 1000; // 10 * 60 seconds = 10 minutes\r\nconst LANG_CHAIN_TIMEOUT = ROUTE_HANDLER_TIMEOUT - 10_000; // 9 minutes 50 seconds\r\nconst CONNECTOR_TIMEOUT = LANG_CHAIN_TIMEOUT - 10_000; // 9 minutes 40 seconds\r\n```\r\n\r\n### Desk testing\r\n\r\n1) Verify there are ~ 100 open alerts in the last 24 hours in your testing environment\r\n\r\n2) Navigate to Security > Attack discovery\r\n\r\n3) Select an Azure / OpenAI connector\r\n\r\n4) Click Generate\r\n\r\n**Expected results**\r\n\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM responds (with the final answer) in less than 2 minutes\r\n- LangSmith displays a single pair of `LLMChain` and `AttackDiscovery` runs when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by the `before` / `after` screenshots in the description above","sha":"1c96c31aee5dc3b9b4f21639cd21e81c200bf76d"}}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Overrides default Attack discovery timeouts
Summary
This PR fixes an issue where Attack discovery requests may be retried when responses from the LLM take longer than two minutes.
In LangSmith, the retry looks like the following before screenshot:
Before
Above: Before the fix, a retry, shown in LangSmith, for an LLM call > 2 minutes
After the fix, a single pair for runs > 2 minutes are observed in LangSmith:
After
Above: After the fix, a single pair in LangSmith, for an LLM call > 2 minutes
Details
This PR overrides the following default timeouts:
The attack discovery route's
idleSocketsocket timeout inx-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.tsThe connector timeout (also in
x-pack/plugins/elastic_assistant/server/routes/attack_discovery/post_attack_discovery.ts)The chain timeout in
x-pack/plugins/security_solution/server/assistant/tools/attack_discovery/attack_discovery_tool.tswith the following defaults:
Desk testing
Verify there are ~ 100 open alerts in the last 24 hours in your testing environment
Navigate to Security > Attack discovery
Select an Azure / OpenAI connector
Click Generate
Expected results
LLMChainandAttackDiscoveryruns when the LLM responds (with the final answer) in less than 2 minutesLLMChainandAttackDiscoveryruns when the LLM takes longer than two minutes to respond (with the final answer), as illustrated by thebefore/afterscreenshots in the description above