[SLO] fix slo locator path #183560
Merged
[SLO] fix slo locator path #183560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mgiota
commented
May 15, 2024
| @@ -29,9 +29,7 @@ export class SloEditLocatorDefinition implements LocatorDefinition<SloEditLocato | |||
| ...slo, | |||
| }, | |||
| { useHash: false, storeInHashQuery: false }, | |||
| slo.id | |||
| ? `${SLO_PREFIX}/edit/${encodeURIComponent(String(slo.id))}` | |||
| : `${SLO_PREFIX}${SLO_CREATE_PATH}` | |||
There was a problem hiding this comment.
@kdelemme I searched for SLO_PREFIX in the slo folder and it looks like it is also used in the slo_details and slo_list locators. I will remove from there as well and will get rid of SLO_PREFIX since it is not used anywhere else. Let me know what you think.
mgiota
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
mgiota
added
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: cc @mgiota |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
Fixes elastic#183428 **Before the fix** https://github.com/elastic/kibana/assets/2852703/c3783c0e-fafa-4fee-8f83-a2a1804ae3c7 **After** https://github.com/elastic/kibana/assets/2852703/f105f967-9c23-46ed-8c9f-1d2f8c288b03 (cherry picked from commit 8b10ce2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[SLO] fix slo locator path (#183560)](#183560) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Panagiota Mitsopoulou","email":"panagiota.mitsopoulou@elastic.co"},"sourceCommit":{"committedDate":"2024-05-16T00:12:53Z","message":"[SLO] fix slo locator path (#183560)\n\nFixes #183428 the fix**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/c3783c0e-fafa-4fee-8f83-a2a1804ae3c7\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/f105f967-9c23-46ed-8c9f-1d2f8c288b03","sha":"8b10ce2f70359fa0537eb89d2ca982bd7a3c8a5b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","ci:project-deploy-observability","Team:obs-ux-management","v8.14.0","v8.15.0"],"title":"[SLO] fix slo locator path","number":183560,"url":"#183560 fix slo locator path (#183560)\n\nFixes #183428 the fix**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/c3783c0e-fafa-4fee-8f83-a2a1804ae3c7\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/f105f967-9c23-46ed-8c9f-1d2f8c288b03","sha":"8b10ce2f70359fa0537eb89d2ca982bd7a3c8a5b"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183560 fix slo locator path (#183560)\n\nFixes #183428 the fix**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/c3783c0e-fafa-4fee-8f83-a2a1804ae3c7\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2852703/f105f967-9c23-46ed-8c9f-1d2f8c288b03","sha":"8b10ce2f70359fa0537eb89d2ca982bd7a3c8a5b"}}]}] BACKPORT--> Co-authored-by: Panagiota Mitsopoulou <panagiota.mitsopoulou@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183428
Before the fix
Screen.Recording.2024-05-15.at.22.18.14.mov
After
Screen.Recording.2024-05-15.at.22.16.47.mov