-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Show upselling component for entity risk score tab #183517
Conversation
3a6ed18
to
dd4a4fc
Compare
/ci |
x-pack/plugins/security_solution_serverless/common/pli/pli_config.ts
Outdated
Show resolved
Hide resolved
868b393
to
28a0c5b
Compare
/ci |
/ci |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@machadoum Thanks for the enhancement. I could see that we also use useHasSecurityCapability('entity-analytics')
to decided if upselling should be displayed. Is there a way to verify this? I assume this is not for checking users' license or product tier?
x-pack/packages/security-solution/upselling/sections/entity_analytics.tsx
Outdated
Show resolved
Hide resolved
x-pack/packages/security-solution/upselling/sections/entity_analytics.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution_ess/public/upselling/register_upsellings.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution_ess/public/upselling/register_upsellings.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution_ess/public/upselling/register_upsellings.tsx
Outdated
Show resolved
Hide resolved
@angorayc Great question. I deleted kibana/x-pack/packages/security-solution/features/src/security/product_feature_config.ts Lines 22 to 32 in 13a968a
|
x-pack/packages/security-solution/upselling/sections/entity_analytics.tsx
Outdated
Show resolved
Hide resolved
x-pack/packages/security-solution/upselling/sections/entity_analytics.tsx
Outdated
Show resolved
Hide resolved
x-pack/packages/security-solution/upselling/pages/entity_analytics.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Pablo for addressing our comments 💯
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
History
To update your PR or re-run it, just comment with: cc @machadoum |
Summary
Before
Serverless: The tab is hidden
ESS: We displayed the unauthorized banner
After
Display the upsell banner
How to test it
For every license and tier
Run security serverless with "Security Analytics Essentials" tier
Run security serverless with "Security Analytics Complete" tier
Run kibana ESS with platinum license
Run kibana ESS with basic license
Checklist
Delete any items that are not applicable to this PR.