Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Show upselling component for entity risk score tab #183517

Merged
merged 10 commits into from
May 22, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented May 15, 2024

Summary

Before

Serverless: The tab is hidden

Screenshot 2024-05-16 at 15 57 36

ESS: We displayed the unauthorized banner

Screenshot 2024-05-16 at 15 38 24

After

Display the upsell banner
Screenshot 2024-05-16 at 14 46 11

How to test it

  • For every license and tier

    • Go to host/user page inside, explore menu item
    • Verify what is displayed inside the risk score tab
  • Run security serverless with "Security Analytics Essentials" tier

    • You should see the upsell component
  • Run security serverless with "Security Analytics Complete" tier

    • You should NOT see the upsell component
  • Run kibana ESS with platinum license

    • You should NOT see the upsell component
  • Run kibana ESS with basic license

    • You should see the upsell component

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum changed the title Siem ea 183227 [SecuritySolution] Show upselling component for entity risk score tab May 16, 2024
@machadoum machadoum force-pushed the siem-ea-183227 branch 2 times, most recently from 3a6ed18 to dd4a4fc Compare May 16, 2024 11:20
@machadoum
Copy link
Member Author

/ci

@machadoum machadoum force-pushed the siem-ea-183227 branch 3 times, most recently from 868b393 to 28a0c5b Compare May 16, 2024 13:37
@machadoum
Copy link
Member Author

/ci

@machadoum
Copy link
Member Author

/ci

@machadoum machadoum marked this pull request as ready for review May 16, 2024 14:38
@machadoum machadoum requested review from a team as code owners May 16, 2024 14:38
@machadoum machadoum self-assigned this May 16, 2024
@machadoum machadoum added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Entity Analytics Security Entity Analytics Team labels May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machadoum Thanks for the enhancement. I could see that we also use useHasSecurityCapability('entity-analytics') to decided if upselling should be displayed. Is there a way to verify this? I assume this is not for checking users' license or product tier?

@machadoum
Copy link
Member Author

machadoum commented May 21, 2024

@angorayc Great question. I deleted useHasSecurityCapability check because it is directly related to the product tier. @semd can explain this better, but useHasSecurityCapability verifies if the user has a privilege for a capability, and privileges for capabilties are injected depending on the product tier.

export const securityDefaultProductFeaturesConfig: DefaultSecurityProductFeaturesConfig = {
[ProductFeatureSecurityKey.advancedInsights]: {
privileges: {
all: {
ui: ['entity-analytics'],
api: [`${APP_ID}-entity-analytics`],
},
read: {
ui: ['entity-analytics'],
api: [`${APP_ID}-entity-analytics`],
},

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Pablo for addressing our comments 💯

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolutionEss 102 108 +6
securitySolutionServerless 127 130 +3
total +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.1MB 15.1MB -165.0B
securitySolutionEss 37.9KB 39.4KB +1.6KB
securitySolutionServerless 97.2KB 111.2KB +13.9KB
total +15.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionEss 15.5KB 16.1KB +526.0B
securitySolutionServerless 19.6KB 20.1KB +538.0B
total +1.0KB
Unknown metric groups

async chunk count

id before after diff
securitySolutionEss 1 3 +2
securitySolutionServerless 10 11 +1
total +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 9d70acc into elastic:main May 22, 2024
38 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants