Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Using Chrome on CI for Cypress #183515

Merged
merged 21 commits into from
May 16, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented May 15, 2024

Summary

Fixes: #183098

Lately we have experienced some issues with our Cypress tests, where we are seeing that tests are passing but the output is marked as a failure.

@patrykkopycinski has done a great job trying to fix the issue but lately we have seen that is still reproducible.

The issue seems to be related directly with electron, so in this PR we reenabling chrome on CI to try to fix it.

In order to do so, some adjustments has been introduced to woraround the chrome out of memory crashes that we faced before and was the main reason to move to electron.

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema self-assigned this May 15, 2024
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 15, 2024
@MadameSheema MadameSheema marked this pull request as ready for review May 15, 2024 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure chromeWebSecurity is being used consistently where needed. LGTM.

@patrykkopycinski
Copy link
Contributor

/ci

@MadameSheema MadameSheema enabled auto-merge (squash) May 16, 2024 07:36
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit a72ddc0 into elastic:main May 16, 2024
39 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 16, 2024
## Summary

Fixes: elastic#183098

Lately we have experienced some issues with our Cypress tests, where we
are seeing that tests are passing but the output is marked as a failure.

@patrykkopycinski has done a great job trying to fix the issue but
lately we have seen that is still reproducible.

The issue seems to be related directly with electron, so in this PR we
reenabling chrome on CI to try to fix it.

In order to do so, some adjustments has been introduced to woraround the
chrome out of memory crashes that we faced before and was the main
reason to move to electron.

---------

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
(cherry picked from commit a72ddc0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@delanni
Copy link
Contributor

delanni commented May 17, 2024

/ci

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 20, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

8 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cypress] Incorrect test summary
8 participants