-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Using Chrome on CI for Cypress #183515
Conversation
/ci |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure chromeWebSecurity
is being used consistently where needed. LGTM.
/ci |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary Fixes: elastic#183098 Lately we have experienced some issues with our Cypress tests, where we are seeing that tests are passing but the output is marked as a failure. @patrykkopycinski has done a great job trying to fix the issue but lately we have seen that is still reproducible. The issue seems to be related directly with electron, so in this PR we reenabling chrome on CI to try to fix it. In order to do so, some adjustments has been introduced to woraround the chrome out of memory crashes that we faced before and was the main reason to move to electron. --------- Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> (cherry picked from commit a72ddc0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
/ci |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
8 similar comments
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Summary
Fixes: #183098
Lately we have experienced some issues with our Cypress tests, where we are seeing that tests are passing but the output is marked as a failure.
@patrykkopycinski has done a great job trying to fix the issue but lately we have seen that is still reproducible.
The issue seems to be related directly with electron, so in this PR we reenabling chrome on CI to try to fix it.
In order to do so, some adjustments has been introduced to woraround the chrome out of memory crashes that we faced before and was the main reason to move to electron.