Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semantic Text UI] Adapt inference endpoint calls to new API spec #183320

Merged

Conversation

saikatsarkar056
Copy link
Contributor

The inference endpoint API spec has changed. Now, we need to refer to 'endpoints' property instead of the 'models' property while gathering the inference_endpoints informations using _inference/_all

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner May 13, 2024 16:37
@saikatsarkar056 saikatsarkar056 self-assigned this May 13, 2024
@saikatsarkar056 saikatsarkar056 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 labels May 13, 2024
@saikatsarkar056 saikatsarkar056 requested review from sphilipse and saarikabhasi and removed request for saarikabhasi and sphilipse May 13, 2024 16:40
@saikatsarkar056 saikatsarkar056 marked this pull request as draft May 13, 2024 16:55
@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review May 13, 2024 17:05
@saikatsarkar056
Copy link
Contributor Author

saikatsarkar056 commented May 13, 2024

We already have several tests that cover the usage of inference_models received from _inference/_all. Should we add additional tests specifically for register_get_route?

@saikatsarkar056 saikatsarkar056 changed the title Adapt inference endpoint calls to new API spec [Semantic Text UI] Adapt inference endpoint calls to new API spec May 13, 2024
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, didn't test locally. I was wondering though if we should add a test to make sure we catch potential ES api changes like this one that would break in kibana.

@sabarasaba
Copy link
Member

Should we add additional tests specifically for register_get_route?

I saw this comment after I left the review, I think it would be a good idea to include some here for sure

Copy link
Member

@saarikabhasi saarikabhasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally. New inference endpoint that are created from inference flyout are shown in the select inference endpoint dropdown
++ on adding additional tests as well.

@sphilipse
Copy link
Member

Yup. Specifically we should have FTR tests that test these endpoints in isolation, as well as FTR tests that run through the UI. And ideally we should have them for both stateful and Serverless.

@saikatsarkar056
Copy link
Contributor Author

Yup. Specifically we should have FTR tests that test these endpoints in isolation, as well as FTR tests that run through the UI. And ideally we should have them for both stateful and Serverless.

@sphilipse I added some FTR tests for the endpoint. I will the FTR tests that run through the UI in a separate PR. Thank you.

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML related changes LGTM.

x-pack/test/functional/services/ml/api.ts Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @saikatsarkar056

@saikatsarkar056 saikatsarkar056 merged commit fe0e1e3 into elastic:main May 16, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants