Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Update grammars #183221

Closed
wants to merge 1 commit into from
Closed

[ES|QL] Update grammars #183221

wants to merge 1 commit into from

Conversation

kibanamachine
Copy link
Contributor

This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner May 13, 2024 04:13
@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels May 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 13, 2024 •
edited

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a filter in where clause in an existing query
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a filter in where clause in an existing query
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a filter out where clause in an existing query
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a filter out where clause in an existing query
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query checking that the value is not null if the user asks for existence
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query checking that the value is not null if the user asks for existence
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query with casting to string when the type is not given
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query with casting to string when the type is not given
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query with casting to string when the type is not string or number
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends a where clause in an existing query with casting to string when the type is not string or number
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends an and clause in an existing query with where command as the last pipe
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends an and clause in an existing query with where command as the last pipe
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends an and clause in an existing query with where command as the last pipe if the filter preexists but the operator is not the correct one
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery appends an and clause in an existing query with where command as the last pipe if the filter preexists but the operator is not the correct one
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery changes the operator in an existing query with where command as the last pipe if the filter preexists but has the opposite operator
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery changes the operator in an existing query with where command as the last pipe if the filter preexists but has the opposite operator
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery changes the operator in an existing query with where command as the last pipe if the filter preexists but has the opposite operator, the field has backticks
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery changes the operator in an existing query with where command as the last pipe if the filter preexists but has the opposite operator, the field has backticks
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery doesnt append anything in an existing query with where command as the last pipe if the exists filter preexists
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery doesnt append anything in an existing query with where command as the last pipe if the exists filter preexists
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery doesnt append anything in an existing query with where command as the last pipe if the filter preexists
  • [job] [logs] Jest Tests #14 / appendToQuery appendWhereClauseToESQLQuery doesnt append anything in an existing query with where command as the last pipe if the filter preexists
  • [job] [logs] Jest Tests #12 / buildDatasourceStates correctly builds esql layer
  • [job] [logs] Jest Tests #12 / buildDatasourceStates correctly builds esql layer
  • [job] [logs] Jest Tests #13 / correctQueryWithActions doesnt complain for @timestamp column
  • [job] [logs] Jest Tests #13 / correctQueryWithActions doesnt complain for @timestamp column
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with 2 syntax errors for stats
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with 2 syntax errors for stats
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with one syntax error for eval
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with one syntax error for eval
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with one syntax error for stats
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with one syntax error for stats
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with two syntax error for eval
  • [job] [logs] Jest Tests #13 / correctQueryWithActions fixes errors correctly for a query with two syntax error for eval
  • [job] [logs] Jest Tests #1 / CreateSourceEditor should preview requested data view on load when mostCommonDataViewId prop provided
  • [job] [logs] Jest Tests #1 / CreateSourceEditor should preview requested data view on load when mostCommonDataViewId prop provided
  • [job] [logs] FTR Configs #49 / dashboard app - group 6 dashboard add ES|QL chart should be able to edit the query and render another chart
  • [job] [logs] FTR Configs #49 / dashboard app - group 6 dashboard add ES|QL chart should be able to edit the query and render another chart
  • [job] [logs] FTR Configs #57 / Discover discover async search should should clean the search session when navigating to ESQL mode, and reinitialize when navigating back
  • [job] [logs] FTR Configs #57 / Discover discover async search should should clean the search session when navigating to ESQL mode, and reinitialize when navigating back
  • [job] [logs] FTR Configs #68 / discover Discover CSV Export Generate CSV: new search generate a report using ES|QL
  • [job] [logs] FTR Configs #68 / discover Discover CSV Export Generate CSV: new search generate a report using ES|QL
  • [job] [logs] FTR Configs #96 / discover/classic discover esql grid with legacy setting should render esql view correctly
  • [job] [logs] FTR Configs #96 / discover/classic discover esql grid with legacy setting should render esql view correctly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #80 / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #80 / discover/esql discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #67 / discover/group2/data_grid2 discover data grid field tokens should render field tokens correctly for ES|QL
  • [job] [logs] FTR Configs #67 / discover/group2/data_grid2 discover data grid field tokens should render field tokens correctly for ES|QL
  • [job] [logs] FTR Configs #11 / discover/group3 discover panels toggle text-based with histogram chart "before all" hook for "sidebar can be toggled"
  • [job] [logs] FTR Configs #11 / discover/group3 discover panels toggle text-based with histogram chart "before all" hook for "sidebar can be toggled"
  • [job] [logs] FTR Configs #30 / discover/group4 discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #30 / discover/group4 discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #97 / discover/group5 discover no data skips to Discover to try ES|QL
  • [job] [logs] FTR Configs #97 / discover/group5 discover no data skips to Discover to try ES|QL
  • [job] [logs] FTR Configs #18 / discover/group6 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #18 / discover/group6 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #57 / discover/group7 discover new search action should work correctly for ESQL mode
  • [job] [logs] FTR Configs #57 / discover/group7 discover new search action should work correctly for ESQL mode
  • [job] [logs] Jest Tests #14 / esql query helpers getIndexPatternFromESQLQuery should return the index pattern string from esql queries
  • [job] [logs] Jest Tests #14 / esql query helpers getIndexPatternFromESQLQuery should return the index pattern string from esql queries
  • [job] [logs] Jest Tests #12 / generates gauge chart config
  • [job] [logs] Jest Tests #12 / generates gauge chart config
  • [job] [logs] Jest Tests #12 / generates gauge chart config with goal and max
  • [job] [logs] Jest Tests #12 / generates gauge chart config with goal and max
  • [job] [logs] Jest Tests #12 / generates metric chart config
  • [job] [logs] Jest Tests #12 / generates metric chart config
  • [job] [logs] Jest Tests #12 / generates region map chart config
  • [job] [logs] Jest Tests #12 / generates region map chart config
  • [job] [logs] Jest Tests #12 / generates table config
  • [job] [logs] Jest Tests #12 / generates table config
  • [job] [logs] Jest Tests #12 / generates tag cloud chart config
  • [job] [logs] Jest Tests #12 / generates tag cloud chart config
  • [job] [logs] Jest Tests #12 / generates xy chart config
  • [job] [logs] Jest Tests #12 / generates xy chart config
  • [job] [logs] Jest Tests #12 / getDatasetIndex extracts index from esql query
  • [job] [logs] Jest Tests #12 / getDatasetIndex extracts index from esql query
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang creates an adhoc dataview if the current dataview is ad hoc and query has changed
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang creates an adhoc dataview if the current dataview is ad hoc and query has changed
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang creates an adhoc dataview if the current dataview is persistent and query has not changed
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang creates an adhoc dataview if the current dataview is persistent and query has not changed
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang returns the current dataview if is adhoc and query has not changed
  • [job] [logs] Jest Tests #7 / getDataViewByTextBasedQueryLang returns the current dataview if is adhoc and query has not changed
  • [job] [logs] Jest Tests #15 / hover functions from a | eval nonExistentFn(numberField) (hover: "nonExistentFn" @ 15 - 28)=> [""]
  • [job] [logs] Jest Tests #15 / hover functions from a | eval nonExistentFn(numberField) (hover: "nonExistentFn" @ 15 - 28)=> [""]
  • [job] [logs] Jest Tests #15 / hover functions from a | eval round(numberField) (hover: "round" @ 15 - 20)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover functions from a | eval round(numberField) (hover: "round" @ 15 - 20)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(nonExistentFn(numberField)) (hover: "nonExistentFn" @ 20 - 33)=> [""]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(nonExistentFn(numberField)) (hover: "nonExistentFn" @ 20 - 33)=> [""]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(round(numberField)) (hover: "avg" @ 16 - 19)=> ["avg(column: number): number","Returns the average of the values in a field"]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(round(numberField)) (hover: "avg" @ 16 - 19)=> ["avg(column: number): number","Returns the average of the values in a field"]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(round(numberField)) (hover: "round" @ 20 - 25)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover functions from a | stats avg(round(numberField)) (hover: "round" @ 20 - 25)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover functions from a | where round(numberField) > 0 (hover: "round" @ 16 - 21)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover functions from a | where round(numberField) > 0 (hover: "round" @ 16 - 21)=> ["round(field: number, decimals:? number): number","Returns a number rounded to the decimal, specified by he closest integer value. The default is to round to an integer."]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _any:policy (hover: "_any" @ 17 - 21)=> ["Cross-clusters query mode","any: Enrich takes place on any cluster"]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _any:policy (hover: "_any" @ 17 - 21)=> ["Cross-clusters query mode","any: Enrich takes place on any cluster"]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _coordinator:policy (hover: "_coordinator" @ 17 - 29)=> ["Cross-clusters query mode","coordinator: Enrich takes place on the coordinating cluster receiving an ES|QL"]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _coordinator:policy (hover: "_coordinator" @ 17 - 29)=> ["Cross-clusters query mode","coordinator: Enrich takes place on the coordinating cluster receiving an ES|QL"]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _remote:policy (hover: "_remote" @ 17 - 24)=> ["Cross-clusters query mode","remote: Enrich takes place on the cluster hosting the target index."]
  • [job] [logs] Jest Tests #15 / hover policies ccq mode from a | enrich _remote:policy (hover: "_remote" @ 17 - 24)=> ["Cross-clusters query mode","remote: Enrich takes place on the cluster hosting the target index."]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b (hover: "non-policy" @ 0 - 10)=> [""]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b (hover: "non-policy" @ 0 - 10)=> [""]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b with var0 = stringField (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] Jest Tests #15 / hover policies from a | enrich policy on b with var0 = stringField (hover: "policy" @ 17 - 23)=> ["Indexes: enrichIndex1","Matching field: otherStringField","Fields: otherField, yetAnotherField, yet-special-field"]
  • [job] [logs] FTR Configs #16 / machine learning - data visualizer esql data visualizer with module_sample_logs ES|QL module_sample_logs displays index details
  • [job] [logs] FTR Configs #16 / machine learning - data visualizer esql data visualizer with module_sample_logs ES|QL module_sample_logs displays index details
  • [job] [logs] FTR Configs #79 / maps app esql "before all" hook for "should display ES|QL statement results on map"
  • [job] [logs] FTR Configs #79 / maps app esql "before all" hook for "should display ES|QL statement results on map"
  • [job] [logs] FTR Configs #36 / Rule execution logic API Detection Engine - Execution logic @ess ES|QL rule type should generate 1 alert with during actual rule execution
  • [job] [logs] FTR Configs #36 / Rule execution logic API Detection Engine - Execution logic @ess ES|QL rule type should generate 1 alert with during actual rule execution
  • [job] [logs] Jest Tests #7 / Test discover state actions loadSavedSearch without id containing ES|QL, adding no warning toast with an invalid index
  • [job] [logs] Jest Tests #7 / Test discover state actions loadSavedSearch without id containing ES|QL, adding no warning toast with an invalid index
  • [job] [logs] Jest Tests #11 / Text based languages utils getIndexPatternFromTextBasedQuery should return the index pattern for es|ql query
  • [job] [logs] Jest Tests #11 / Text based languages utils getIndexPatternFromTextBasedQuery should return the index pattern for es|ql query
  • [job] [logs] Jest Tests #11 / Text based languages utils getStateFromAggregateQuery should return the correct state
  • [job] [logs] Jest Tests #11 / Text based languages utils getStateFromAggregateQuery should return the correct state
  • [job] [logs] Jest Tests #11 / Text based languages utils getStateFromAggregateQuery should return the correct state for not existing dataview
  • [job] [logs] Jest Tests #11 / Text based languages utils getStateFromAggregateQuery should return the correct state for not existing dataview
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should display the selected fields accordion if there are fields displayed
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should display the selected fields accordion if there are fields displayed
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should list all supported fields in the pattern
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should list all supported fields in the pattern
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should list all supported fields in the pattern that match the search input
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should list all supported fields in the pattern that match the search input
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should not display the selected fields accordion if there are no fields displayed
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should not display the selected fields accordion if there are no fields displayed
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should render a search box
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should render a search box
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should render correct field type icons
  • [job] [logs] Jest Tests #11 / TextBased Query Languages Data Panel should render correct field type icons
  • [job] [logs] Jest Tests #9 / useEsqlIndex should return parsed index array from a valid query
  • [job] [logs] Jest Tests #9 / useEsqlIndex should return parsed index array from a valid query
  • [job] [logs] Jest Tests #13 / VisualizeESQL should display the errors if given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should display the errors if given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should not run the suggestions api if no initial input is given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should not run the suggestions api if no initial input is given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should render the embeddable if no initial input is given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should render the embeddable if no initial input is given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should run the setVisibility callback if edit button is clicked
  • [job] [logs] Jest Tests #13 / VisualizeESQL should run the setVisibility callback if edit button is clicked
  • [job] [logs] Jest Tests #13 / VisualizeESQL should run the suggestions api if no initial input is given
  • [job] [logs] Jest Tests #13 / VisualizeESQL should run the suggestions api if no initial input is given

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.1MB 3.1MB +6.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@drewdaemon this is the PR elastic/elasticsearch#108115 that introduced this change

@drewdaemon
Copy link
Contributor

Closing since these changes conflict with #183656. The bot will open a new PR next week.

@drewdaemon drewdaemon closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kibanamachine @elasticmachine @kibana-ci @stratoula @drewdaemon