-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Enable Synthetics menu to be searched in the global search bar #182613
[Synthetics] Enable Synthetics menu to be searched in the global search bar #182613
Conversation
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
defaultMessage: 'Monitors', | ||
}), | ||
title: this._isServerless | ||
? i18n.translate('xpack.synthetics.overviewPage.serverless.linkText', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes the search result consistent with the menu item in serverless
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
…ch bar (elastic#182613) closes [elastic#181974](elastic#181974) ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="1144" alt="image" src="https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781"> <img width="1148" alt="image" src="https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73"> ### How to test - run `yarn es serverless --projectType=oblt --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true` - run `yarn serverless-oblt` - type Synthetics in the top searchbar - do the same in stateful Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0b8f97f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…al search bar (#182613) (#182684) # Backport This will backport the following commits from `main` to `8.14`: - [[Synthetics] Enable Synthetics menu to be searched in the global search bar (#182613)](#182613) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-06T13:21:21Z","message":"[Synthetics] Enable Synthetics menu to be searched in the global search bar (#182613)\n\ncloses [#181974](#181974 Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n<img width=\"1144\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img width=\"1148\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n### How to test\r\n- run `yarn es serverless --projectType=oblt --kill --clean --license\r\ntrial -E xpack.security.authc.api_key.enabled=true`\r\n- run `yarn serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the same in stateful\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Synthetics","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.15.0"],"title":"[Synthetics] Enable Synthetics menu to be searched in the global search bar","number":182613,"url":"#182613 Enable Synthetics menu to be searched in the global search bar (#182613)\n\ncloses [#181974](#181974 Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n<img width=\"1144\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img width=\"1148\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n### How to test\r\n- run `yarn es serverless --projectType=oblt --kill --clean --license\r\ntrial -E xpack.security.authc.api_key.enabled=true`\r\n- run `yarn serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the same in stateful\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182613 Enable Synthetics menu to be searched in the global search bar (#182613)\n\ncloses [#181974](#181974 Summary\r\n\r\nSummarize your PR. If it involves visual changes include a screenshot or\r\ngif.\r\n<img width=\"1144\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img width=\"1148\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n### How to test\r\n- run `yarn es serverless --projectType=oblt --kill --clean --license\r\ntrial -E xpack.security.authc.api_key.enabled=true`\r\n- run `yarn serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the same in stateful\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
closes #181974
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
How to test
yarn es serverless --projectType=oblt --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true
yarn serverless-oblt