Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Enable Synthetics menu to be searched in the global search bar #182613

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented May 3, 2024

closes #181974

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.
image

image

How to test

  • run yarn es serverless --projectType=oblt --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true
  • run yarn serverless-oblt
  • type Synthetics in the top searchbar
  • do the same in stateful

@crespocarlos
Copy link
Contributor Author

/ci

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes Synthetics backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.15.0 Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 6, 2024
defaultMessage: 'Monitors',
}),
title: this._isServerless
? i18n.translate('xpack.synthetics.overviewPage.serverless.linkText', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the search result consistent with the menu item in serverless

@crespocarlos crespocarlos marked this pull request as ready for review May 6, 2024 11:32
@crespocarlos crespocarlos requested a review from a team as a code owner May 6, 2024 11:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 6, 2024
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crespocarlos crespocarlos changed the title Enable Synthetics menu to be searched in the global search bar [Synthetics] Enable Synthetics menu to be searched in the global search bar May 6, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 19.5KB 19.5KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit 0b8f97f into elastic:main May 6, 2024
22 checks passed
@crespocarlos crespocarlos deleted the 181974-enable-synthetics-in-global-search branch May 6, 2024 13:21
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 6, 2024
…ch bar (elastic#182613)

closes [elastic#181974](elastic#181974)

## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.
<img width="1144" alt="image"
src="https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781">

<img width="1148" alt="image"
src="https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73">

### How to test
- run `yarn es serverless --projectType=oblt --kill --clean --license
trial -E xpack.security.authc.api_key.enabled=true`
- run `yarn serverless-oblt`
- type Synthetics in the top searchbar
- do the same in stateful

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0b8f97f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 6, 2024
…al search bar (#182613) (#182684)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Synthetics] Enable Synthetics menu to be searched in the global
search bar (#182613)](#182613)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-06T13:21:21Z","message":"[Synthetics]
Enable Synthetics menu to be searched in the global search bar
(#182613)\n\ncloses
[#181974](#181974
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot or\r\ngif.\r\n<img width=\"1144\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img
width=\"1148\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n###
How to test\r\n- run `yarn es serverless --projectType=oblt --kill
--clean --license\r\ntrial -E
xpack.security.authc.api_key.enabled=true`\r\n- run `yarn
serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the
same in stateful\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Synthetics","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.15.0"],"title":"[Synthetics]
Enable Synthetics menu to be searched in the global search
bar","number":182613,"url":"#182613
Enable Synthetics menu to be searched in the global search bar
(#182613)\n\ncloses
[#181974](#181974
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot or\r\ngif.\r\n<img width=\"1144\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img
width=\"1148\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n###
How to test\r\n- run `yarn es serverless --projectType=oblt --kill
--clean --license\r\ntrial -E
xpack.security.authc.api_key.enabled=true`\r\n- run `yarn
serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the
same in stateful\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182613
Enable Synthetics menu to be searched in the global search bar
(#182613)\n\ncloses
[#181974](#181974
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot or\r\ngif.\r\n<img width=\"1144\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/5d26f562-bf9f-44e4-a9d8-e3d4a2d0e781\">\r\n\r\n<img
width=\"1148\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/7370fbf2-27fb-4de3-84ff-b2f3ade8ee73\">\r\n\r\n\r\n###
How to test\r\n- run `yarn es serverless --projectType=oblt --kill
--clean --license\r\ntrial -E
xpack.security.authc.api_key.enabled=true`\r\n- run `yarn
serverless-oblt`\r\n- type Synthetics in the top searchbar\r\n- do the
same in stateful\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0b8f97ff393ef08dcb5f70793e5c960a7ccd091f"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Synthetics Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Enable Synthetics pages to Kibana's global search
7 participants