Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric Viewer: fixes hover functionality in the anomalies table #182297

Merged
merged 1 commit into from
May 2, 2024

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented May 1, 2024

Summary

Fixes hover functionality for the anomalies table in the Single Metric Viewer to highlight the corresponding marker in the chart.

Issue mentioned in #181910 (comment)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.2MB 4.2MB +18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@peteharverson peteharverson changed the title [ML] Single Metric Viewer: ensure anomaly hover functionality is working [ML] Single Metric Viewer: fixes hover functionality in the anomalies table May 2, 2024
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@alvarezmelissa87 alvarezmelissa87 merged commit 2d71451 into elastic:main May 2, 2024
29 checks passed
@alvarezmelissa87 alvarezmelissa87 deleted the ml-smv-table-fix branch May 2, 2024 14:44
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2024
… table (elastic#182297)

## Summary

Fixes hover functionality for the anomalies table in the Single Metric
Viewer to highlight the corresponding marker in the chart.

Issue mentioned in
elastic#181910 (comment)

(cherry picked from commit 2d71451)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2024
…omalies table (#182297) (#182389)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[ML] Single Metric Viewer: fixes hover functionality in the anomalies
table (#182297)](#182297)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2024-05-02T14:44:18Z","message":"[ML]
Single Metric Viewer: fixes hover functionality in the anomalies table
(#182297)\n\n## Summary\r\n\r\nFixes hover functionality for the
anomalies table in the Single Metric\r\nViewer to highlight the
corresponding marker in the chart.\r\n\r\nIssue mentioned
in\r\nhttps://github.com//issues/181910#issuecomment-2082456621","sha":"2d71451d1f88ae1f850875eccd1c6d299f5f0e70","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","v8.14.0","v8.15.0"],"title":"[ML] Single Metric Viewer:
fixes hover functionality in the anomalies
table","number":182297,"url":"#182297
Single Metric Viewer: fixes hover functionality in the anomalies table
(#182297)\n\n## Summary\r\n\r\nFixes hover functionality for the
anomalies table in the Single Metric\r\nViewer to highlight the
corresponding marker in the chart.\r\n\r\nIssue mentioned
in\r\nhttps://github.com//issues/181910#issuecomment-2082456621","sha":"2d71451d1f88ae1f850875eccd1c6d299f5f0e70"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182297
Single Metric Viewer: fixes hover functionality in the anomalies table
(#182297)\n\n## Summary\r\n\r\nFixes hover functionality for the
anomalies table in the Single Metric\r\nViewer to highlight the
corresponding marker in the chart.\r\n\r\nIssue mentioned
in\r\nhttps://github.com//issues/181910#issuecomment-2082456621","sha":"2d71451d1f88ae1f850875eccd1c6d299f5f0e70"}}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
… table (elastic#182297)

## Summary

Fixes hover functionality for the anomalies table in the Single Metric
Viewer to highlight the corresponding marker in the chart.

Issue mentioned in
elastic#181910 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants