Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Fixing pattern analysis action buttons layout #181960

Merged
merged 3 commits into from Apr 29, 2024
Merged

[ML] AIOps: Fixing pattern analysis action buttons layout #181960

merged 3 commits into from Apr 29, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 29, 2024 •
edited by peteharverson

Widening actions column width.

Before

image

After
image

Also fixes similar issue with the annotations table in the anomaly explorer.

Issue introduced in #180514

@jgowdyelastic jgowdyelastic self-assigned this Apr 29, 2024
@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.14.0 labels Apr 29, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review April 29, 2024 10:56
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 29, 2024 10:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #42 / serverless observability UI Dataset Quality Dataset quality flyout goes to log explorer for degraded docs when show all is clicked

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@jgowdyelastic jgowdyelastic merged commit 3609f88 into elastic:main Apr 29, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 29, 2024
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
@jgowdyelastic @yuliacech
[ML] AIOps: Fixing pattern analysis action buttons layout (elastic#18…
de93ca5 
…1960)

Widening actions column width.

**Before**


![image](https://github.com/elastic/kibana/assets/22172091/cd39d806-4bf1-4697-a15b-ceede90bd730)


**After**

![image](https://github.com/elastic/kibana/assets/22172091/6bf738a5-f110-4cf3-b530-e147341e1414)

Also fixes similar issue with the annotations table in the anomaly
explorer.

Issue introduced in elastic#180514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @kibana-ci @peteharverson @kibanamachine