[ESLint I18n Rule] Cleanup #181959
Merged
[ESLint I18n Rule] Cleanup #181959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
added
the
release_note:skip
CoenWarmer
commented
Apr 29, 2024
| node.range, | ||
| `i18n.translate('${newI18nIdentifier}', ${opts})` | ||
| ); | ||
| return [ |
There was a problem hiding this comment.
2 main changes:
1: Added the additional fixer which adds an import { i18n } from '@kbn/i18n' line to the imports if it wasn't there before.
2: In the previous approach we targeted the whole i18n.translate() node and reconstructed it by using the correct first parameter and getting the existing options object (if any) from the source code. Now we are a bit smarter still: we don't target the full node, we target the node of the first parameter, we just update that with the correct identifier and keep the rest of the code intact.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 29, 2024
kibanamachine
added
v8.15.0
backport:skip
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Just a tiny cleanup PR that was leftover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a tiny cleanup PR that was leftover.