Remove duplicates from inference_endpoint combo #181935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikatsarkar056
added
v8.15.0
backport:skip
...mponents/mappings_editor/components/document_fields/field_parameters/select_inference_id.tsx
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sphilipse
approved these changes
May 6, 2024
yuliacech
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thanks a lot for adding the tests, @saikatsarkar056!
Code changes LGTM, didn't test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the default inference_endpoint doesn't exist, a new one is created for the user whenever they click 'Add field'. However, this results in the newly created inference_endpoint being displayed as a duplicate in the inference_id combo selection.
In PR covers the following: