[Security Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?) #181894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
alert-details-flyout-panel-keys
branch
from
a22bf3f
to
bd93aca
Compare
…ile to avoid weird webpack issue (circular dependency?)
PhilippeOberti
force-pushed
the
alert-details-flyout-panel-keys
branch
from
bd93aca
to
3ec29d8
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
approved these changes
Apr 26, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Apr 26, 2024
…ile to avoid weird webpack issue (circular dependency?) (elastic#181894) (cherry picked from commit 0a9ad29) # Conflicts: # x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx
semd
reviewed
Apr 29, 2024
x-pack/plugins/security_solution/public/flyout/document_details/shared/constants/panel_keys.ts
Show resolved
Hide resolved
PhilippeOberti
added a commit
that referenced
this pull request
Apr 29, 2024
…stant file to avoid weird webpack issue (circular dependency?) (#181894) (#181929) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?) (#181894)](#181894) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-04-26T22:00:34Z","message":"[Security Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?) (#181894)","sha":"0a9ad2956ebb77829ec860d8511d74244aceddc8","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"number":181894,"url":"#181894 Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?) (#181894)","sha":"0a9ad2956ebb77829ec860d8511d74244aceddc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#181894 Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?) (#181894)","sha":"0a9ad2956ebb77829ec860d8511d74244aceddc8"}}]}] BACKPORT-->
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…ile to avoid weird webpack issue (circular dependency?) (elastic#181894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While making a very small change to the note_previews component (see pending PR), I noticed some jest tests failing. Those tests seem to be completely unrelated to the changes made in the PR... After investigation, the issues comes from the
DocumentDetailsRightPanelKeyconstant that we import. There must be some sort of circular dependency, or something Webpack isn't happy about...This current PR only extracts those constants to a separate file. This fixes the jest tests failing in the PR mentioned above.
Absolutely no code changes are implemented, other than extracting the constants and updating all the imports.
Will help merge this, so indirectly addresses this bug