[VRT] Update more reference images #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- faker.date updated periodically to match the same time distance to a reference date which updated the data
faker.date somehow has influence on the other faker data calls which is why the images update more than expected
…mages after previous style changes
mgadewoll
added
documentation
mgadewoll
changed the title
cee-chen
approved these changes
May 15, 2024
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds/updates VRT reference images for some component stories.
A couple images were missing though they had been added before. This might have been a hiccup when rebasing with the monorepo changes.
The other updated images are a result of us not running VRT again after changes 🙈
ℹ️ Additionally, this PR updates the story of
EuiDataGridasfaker.date.past()seems to not be stable enough.The faker date is locked to a certain time distance (1 year) which results in updated dates with progressing time.
This PR removes this usage in favor of static dates.
Funnily enough the call to
faker.date.past()had an influence on the other faker data calls, which is why theEuiDataGridimages updated more than expected. 🤷♀️QA