Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps version to 7.2.0 #1034

Closed
wants to merge 2 commits into from
Closed

Bumps version to 7.2.0 #1034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb6e92
Update ruby2_keywords definition
AZanellato Jun 15, 2022
b1d3485
Remove old code
AZanellato Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions elasticsearch-model/lib/elasticsearch/model/proxy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

def ruby2_keywords(*) # :nodoc:
end if RUBY_VERSION < "2.7"
module Elasticsearch
module Model

Expand Down Expand Up @@ -114,10 +115,7 @@ module Base
def initialize(target)
@target = target
end

def ruby2_keywords(*) # :nodoc:
end if RUBY_VERSION < "2.7"


# Delegate methods to `@target`. As per [the Ruby 3.0 explanation for keyword arguments](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/), the only way to work on Ruby <2.7, and 2.7, and 3.0+ is to use `ruby2_keywords`.
#
ruby2_keywords def method_missing(method_name, *arguments, &block)
Expand Down