Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version to 7.2.0 #1034

Closed
wants to merge 2 commits into from
Closed

Bumps version to 7.2.0 #1034

wants to merge 2 commits into from

Conversation

AZanellato
Copy link

This defines the ruby2_keywords method at the top of the file, given that it needs to be a top level method

This fixes #1024

This needs to be on the top level so it can be called on the load
@jonathan-at-leavelogic
Copy link

I'm running into this issue, too. Can this PR be merged?

Copy link

@habib-ali habib-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue

P.S
Nevermind my above comment.

Looking at the link present in the line

# Delegate methods to `@target`. As per [the Ruby 3.0 explanation for keyword arguments](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/), the only way to work on Ruby <2.7, and 2.7, and 3.0+ is to use `ruby2_keywords`.

I found at that using gem 'ruby2_keywords', '~> 0.0.5' in the Gemfile solves this issue

@AZanellato AZanellato closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined method ruby2_keywords for Elasticsearch::Model::Proxy::Base:Module
4 participants