Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UrlFormatter #108

Merged
merged 1 commit into from Apr 17, 2024
Merged

Improve UrlFormatter #108

merged 1 commit into from Apr 17, 2024

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Apr 16, 2024

Improvements to CreateString:

  1. The IEnumerable<object> was never matching (except for exact this type). I changed the code to check for IEnumerable instead
  2. To support arrays with non-zero lower bounds, I kept the Array special case
  3. For performance reasons (saving one iterator instance and being able to use for instead of foreach) I special cased IList

Besides that, I fixed some nullability annotations.

Fixes: elastic/elasticsearch-net#8034

@flobernd flobernd added bug Something isn't working v0.4.19 labels Apr 16, 2024
@flobernd
Copy link
Member Author

CI fails for unrelated reasons it seems.

@flobernd flobernd merged commit 75c32f9 into main Apr 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.4.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicies.Get call fails to deserialize ICollections properly in the IndexRequest
2 participants