Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cleanup systemtest init #12448

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kruskall
Copy link
Member

Motivation/summary

we don't need to upload apmpackage so we can cleanup the init code. Avoid cleaning es during init, it should be cleaned in specific tests to support the -count flag.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

we don't need to upload apmpackage so we can cleanup the init code.
Avoid cleaning es during init, it should be cleaned in specific tests to
support the -count flag.
@kruskall kruskall requested a review from a team as a code owner January 17, 2024 20:06
Copy link
Contributor

mergify bot commented Jan 17, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 17, 2024
@v1v
Copy link
Member

v1v commented Feb 9, 2024

run docs-build

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid cleaning es during init, it should be cleaned in specific tests to support the -count flag.

which -count flag are you referring to?

@kruskall
Copy link
Member Author

which -count flag are you referring to?

the builtin -count flag for go test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants