Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apm docs consolidation] 8.7: Delete moved files, update README #12359

Open
wants to merge 3 commits into
base: 8.7
Choose a base branch
from

Conversation

colleenmcginnis
Copy link
Contributor

Related to #12341

@colleenmcginnis
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@colleenmcginnis
Copy link
Contributor Author

The docs build passed. 🤷‍♀️ I'm not familiar with the failing checks.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 12, 2024 19:11
@colleenmcginnis colleenmcginnis requested a review from a team January 12, 2024 19:11
@carsonip
Copy link
Member

carsonip commented Jan 15, 2024

diff --git a/NOTICE.txt b/NOTICE.txt
index 30c9e6c0c..51405e382 100644
--- a/NOTICE.txt
+++ b/NOTICE.txt
@@ -1,5 +1,5 @@
 Elastic APM Server
-Copyright 2014-2023 Elasticsearch BV
+Copyright 2014-2024 Elasticsearch BV
 
 This product includes software developed by The Apache Software 
 Foundation (http://www.apache.org/).

8.8 backport PR #12358 is passing CI because there's a shortcut for docs to bypass the lint check #10564 . We either 1. fix the year in NOTICE.txt for all old branches like we did in #12333; or 2. update CI to bypass the check for docs PRs. I like the latter better.

@carsonip
Copy link
Member

CI because there's a shortcut for docs to bypass the lint check

actually, the same bypass exists for 8.7 branch, but because there are .yml files deleted in the PR, it triggers the lint job instead of bypassing it.

@bmorelli25
Copy link
Member

bmorelli25 commented Jan 16, 2024

Is it worth doing that for all of these branches? Or can we just merge this because these are the last docs PRs that will ever go into these branches?

Edit: I'm going to update the notice.txt

@v1v
Copy link
Member

v1v commented Feb 9, 2024

run docs-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants