Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add version in which the configurations were added #1134 #1788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add version in which the configurations were added #1134 #1788

wants to merge 1 commit into from

Conversation

adityahiran
Copy link

Closes #1134. For more info see: #1134

Checklist

[X] Update documentation

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
161e542

Please, read and sign the above mentioned agreement if you want to contribute to this project

@apmmachine
Copy link
Collaborator

apmmachine commented Jul 4, 2020 •
edited

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2020-12-09T00:59:17.100+0000

  • Duration: 3 min 8 sec

  • Commit: 161e542

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Log output

Expand to view the last 100 lines of log output 

[2020-12-09T01:01:58.787Z] Using shallow fetch with depth 3
[2020-12-09T01:01:58.787Z] Pruning obsolete local branches
[2020-12-09T01:01:58.709Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-nodejs.git # timeout=10
[2020-12-09T01:01:58.721Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-12-09T01:01:58.740Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-nodejs.git # timeout=10
[2020-12-09T01:01:58.764Z]  > git rev-parse --verify HEAD # timeout=10
[2020-12-09T01:01:58.775Z] No valid HEAD. Skipping the resetting
[2020-12-09T01:01:58.776Z]  > git clean -fdx # timeout=10
[2020-12-09T01:01:58.793Z] Fetching upstream changes from git@github.com:elastic/apm-agent-nodejs.git
[2020-12-09T01:01:58.793Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-09T01:01:58.802Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/apm-agent-nodejs.git +refs/pull/1788/head:refs/remotes/origin/PR-1788 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-12-09T01:01:59.467Z] Merging remotes/origin/master commit c6c50653599e2cbe71de3baa6780bb0af32d14b3 into PR head commit 161e54274942feafb2c70238502b34e5f143f059
[2020-12-09T01:01:59.656Z] Merge succeeded, producing 6c5b44ce36159e8073f407e423982dc0639c57de
[2020-12-09T01:01:59.657Z] Checking out Revision 6c5b44ce36159e8073f407e423982dc0639c57de (PR-1788)
[2020-12-09T01:01:59.474Z]  > git config core.sparsecheckout # timeout=10
[2020-12-09T01:01:59.479Z]  > git checkout -f 161e54274942feafb2c70238502b34e5f143f059 # timeout=15
[2020-12-09T01:01:59.546Z]  > git remote # timeout=10
[2020-12-09T01:01:59.550Z]  > git config --get remote.origin.url # timeout=10
[2020-12-09T01:01:59.556Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-09T01:01:59.560Z]  > git merge c6c50653599e2cbe71de3baa6780bb0af32d14b3 # timeout=10
[2020-12-09T01:01:59.624Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-12-09T01:01:59.667Z]  > git config core.sparsecheckout # timeout=10
[2020-12-09T01:01:59.728Z]  > git checkout -f 6c5b44ce36159e8073f407e423982dc0639c57de # timeout=15
[2020-12-09T01:02:03.568Z] Commit message: "Merge commit 'c6c50653599e2cbe71de3baa6780bb0af32d14b3' into HEAD"
[2020-12-09T01:02:03.588Z] First time build. Skipping changelog.
[2020-12-09T01:02:03.588Z] Cleaning workspace
[2020-12-09T01:02:03.572Z]  > git rev-list --no-walk 564e9d5ebb715c50fe55c0be0905248ec99d182f # timeout=10
[2020-12-09T01:02:03.591Z]  > git rev-parse --verify HEAD # timeout=10
[2020-12-09T01:02:03.596Z] Resetting working tree
[2020-12-09T01:02:03.596Z]  > git reset --hard # timeout=10
[2020-12-09T01:02:03.629Z]  > git clean -fdx # timeout=10
[2020-12-09T01:02:04.549Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-12-09T01:02:04.616Z] Timeout set to expire in 3 hr 0 min
[2020-12-09T01:02:04.636Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-12-09T01:02:04.893Z] [INFO] Number of builds to be searched 10
[2020-12-09T01:02:05.137Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-12-09T01:02:05.158Z] Running in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1788/src/github.com/elastic/apm-agent-nodejs
[2020-12-09T01:02:05.181Z] [INFO] gitCheckout: Checkout SCM PR-1788 with some customisation.
[2020-12-09T01:02:05.213Z] [INFO] Override default checkout
[2020-12-09T01:02:05.261Z] Sleeping for 10 sec
[2020-12-09T01:02:15.405Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-12-09T01:02:15.515Z] Cloning the remote Git repository
[2020-12-09T01:02:15.533Z] Cloning repository git@github.com:elastic/apm-agent-nodejs.git
[2020-12-09T01:02:15.563Z]  > git init /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1788/src/github.com/elastic/apm-agent-nodejs # timeout=10
[2020-12-09T01:02:15.579Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-nodejs.git
[2020-12-09T01:02:15.580Z] Fetching upstream changes from git@github.com:elastic/apm-agent-nodejs.git
[2020-12-09T01:02:15.580Z]  > git --version # timeout=10
[2020-12-09T01:02:15.597Z]  > git --version # 'git version 2.17.1'
[2020-12-09T01:02:15.597Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-09T01:02:15.602Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-nodejs.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-12-09T01:02:17.083Z] Checking out Revision 161e54274942feafb2c70238502b34e5f143f059 (origin/PR-1788)
[2020-12-09T01:02:17.138Z] Commit message: "docs: add version in which the configurations were added #1134"
[2020-12-09T01:02:17.138Z] First time build. Skipping changelog.
[2020-12-09T01:02:16.480Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-nodejs.git # timeout=10
[2020-12-09T01:02:16.483Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-12-09T01:02:16.492Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-nodejs.git # timeout=10
[2020-12-09T01:02:16.500Z] Fetching upstream changes from git@github.com:elastic/apm-agent-nodejs.git
[2020-12-09T01:02:16.500Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-12-09T01:02:16.503Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-nodejs.git +refs/pull/1788/head:refs/remotes/origin/PR-1788 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2020-12-09T01:02:17.076Z]  > git rev-parse origin/PR-1788^{commit} # timeout=10
[2020-12-09T01:02:17.087Z]  > git config core.sparsecheckout # timeout=10
[2020-12-09T01:02:17.091Z]  > git checkout -f 161e54274942feafb2c70238502b34e5f143f059 # timeout=10
[2020-12-09T01:02:18.058Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-12-09T01:02:18.729Z] + git fetch https://****:****@github.com/elastic/apm-agent-nodejs.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2020-12-09T01:02:19.365Z] Running in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1788/src/github.com/elastic/apm-agent-nodejs/.git
[2020-12-09T01:02:19.390Z] Archiving artifacts
[2020-12-09T01:02:20.116Z] + git rev-parse HEAD
[2020-12-09T01:02:20.493Z] + git rev-parse HEAD
[2020-12-09T01:02:20.811Z] + git rev-parse origin/pr/1788
[2020-12-09T01:02:20.879Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-12-09T01:02:21.257Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-12-09T01:02:22.292Z] [INFO] githubPrCheckApproved: Title: docs: add version in which the configurations were added #1134 - User: adityahiran - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-12-09T01:02:22.588Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-12-09T01:02:22.588Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-12-09T01:02:22.623Z] [INFO] Let's stop build #29. The PR is not allowed to run in the CI yet
[2020-12-09T01:02:22.640Z] Sleeping for 5 sec
[2020-12-09T01:02:23.701Z] Stage "Test" skipped due to earlier failure(s)
[2020-12-09T01:02:23.744Z] Stage "TAV Test" skipped due to earlier failure(s)
[2020-12-09T01:02:23.787Z] Stage "Edge Test" skipped due to earlier failure(s)
[2020-12-09T01:02:23.842Z] Stage "Nightly Test" skipped due to earlier failure(s)
[2020-12-09T01:02:23.843Z] Stage "Nightly Test - No async hooks" skipped due to earlier failure(s)
[2020-12-09T01:02:23.844Z] Stage "RC Test" skipped due to earlier failure(s)
[2020-12-09T01:02:23.845Z] Stage "RC Test - No async hooks" skipped due to earlier failure(s)
[2020-12-09T01:02:23.896Z] Failed in branch Nightly Test
[2020-12-09T01:02:23.897Z] Failed in branch Nightly Test - No async hooks
[2020-12-09T01:02:23.898Z] Failed in branch RC Test
[2020-12-09T01:02:23.898Z] Failed in branch RC Test - No async hooks
[2020-12-09T01:02:23.961Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-12-09T01:02:24.004Z] Stage "Release" skipped due to earlier failure(s)
[2020-12-09T01:02:24.025Z] Stage "Release" skipped due to earlier failure(s)
[2020-12-09T01:02:24.093Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-12-09T01:02:24.407Z] Running on worker-1225339 in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1788
[2020-12-09T01:02:24.521Z] [INFO] getVaultSecret: Getting secrets
[2020-12-09T01:02:24.770Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-12-09T01:02:26.781Z] + chmod 755 generate-build-data.sh
[2020-12-09T01:02:26.781Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1788/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1788/runs/29 ABORTED 188286
[2020-12-09T01:02:26.781Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1788/runs/29/steps/?limit=10000 -o steps-info.json
[2020-12-09T01:02:28.233Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1788/runs/29/tests/?status=FAILED -o tests-errors.json
[2020-12-09T01:02:28.233Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2020-12-09T01:02:29.685Z] Retry 2/3 exited 22, retrying in 2 seconds...

@adityahiran
Copy link
Author

Signed the contributors agreement.

@adityahiran adityahiran closed this Jul 4, 2020
@adityahiran adityahiran reopened this Jul 4, 2020
vigneshshanmugam
vigneshshanmugam reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Left few comments and suggestions. Also you have missed out some options

  • ignoreUrls
  • ignoreUserAgents
  • logger

docs/configuration.asciidoc
@@ -61,6 +69,8 @@ The URL to where the APM Server is deployed.
[[validate-server-cert]]
==== `verifyServerCert`

[small]#Added in: v0.3.0#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[small]#Added in: v0.3.0#
[small]#Added in: v1.0.0#

docs/configuration.asciidoc
@@ -803,6 +897,8 @@ ELASTIC_APM_GLOBAL_LABELS="subspace=sap-hana,rack=number6"
[[config-file]]
==== `configFile`

[small]#Added in: v0.3.0#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[small]#Added in: v0.3.0#
[small]#Added in: v2.16.0#

docs/configuration.asciidoc
@@ -491,6 +545,8 @@ Use the following two config options to change how many lines of source code to
[[source-context-error-app-frames]]
*`sourceLinesErrorAppFrames`*

[small]#Added in: v0.12.0#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[small]#Added in: v0.12.0#
[small]#Added in: v1.0.0#

docs/configuration.asciidoc
@@ -503,6 +559,8 @@ Setting this config option to `0` means that no source code will be collected fo
[[source-context-error-library-frames]]
*`sourceLinesErrorLibraryFrames`*

[small]#Added in: v0.12.0#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[small]#Added in: v0.12.0#
[small]#Added in: v1.0.0#

@trentm trentm added the agent-nodejs Make available for APM Agents project planning. label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve config docs with "Added in" info
4 participants
@adityahiran @apmmachine @vigneshshanmugam @trentm