-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust sizing and color of new paella icons #1165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I like that the icon is smaller, but now it's also smaller for small screens. What about keeping the
width: 20%
, but addmax-width: 150px
? I like the sizes on all screen sizes then. -
I like the thinner stroke width of the icon.
-
Regarding color and shadow: I think the previous version was better. Generally, we do need the shadow as otherwise, regardless of what color we chose, there will be a preview image that ruins everything. The blurred shadow is not quite the prettiest, but I think it looks alright. We can also reduce the blur radius to 1.5px or 1px and instead make the shadow color darker, e.g. black. Then it's sharper.
Just a reminder we wanted to test the new design with different videos: "I would suggest you take a look at a couple of videos with different backgrounds. I still think the lighter version works better for a variety of backgrounds, but if as you said the majority of videos will have a white background anyway, the darker version should be ok to use." (Ole) |
Thanks Ole for the comparison. My position remains the same as yours: I prefer the white icon. |
Yes, white is the colour to work with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This makes the new play and spinner icons slightly smaller and thinner, and uses a darker grey.