Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slide segments and extracted text to harvesting and DB, enable paella slide previews #1163

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Apr 26, 2024

This adds the ocr'd slide texts as well as a list of timestamped frames to the harvesting sync code and stores them in the DB.
In order the show the slide previews, paella-slide-plugins was added and configured to use the timestamped frames.

Needs opencast/opencast#5757 to work. Once that is merged, released and used on our test Opencast, the changes can be tested with fresh uploads. We'll still need some mechanism to apply segmentation and ocr (and speech-to-text as well) to existing videos.

(Can be reviewed commit by commit, though note that the migration from the second commit was extended in the third)

@owi92 owi92 added the changelog:user User facing changes label Apr 26, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 April 26, 2024 13:03 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 April 26, 2024 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 April 26, 2024 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 April 26, 2024 14:36 Destroyed
@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Apr 29, 2024

This comment was marked as resolved.

@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Apr 29, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 April 29, 2024 15:22 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just code review, no testing yet)
Looks overall pretty good. I have a few small nits, but there is only one bigger one: about how to store the startTime.

backend/src/db/migrations.rs Outdated Show resolved Hide resolved
backend/src/db/migrations/32-event-slide-data.sql Outdated Show resolved Hide resolved
frontend/src/ui/player/Paella.tsx Outdated Show resolved Hide resolved
backend/src/db/migrations/32-event-slide-data.sql Outdated Show resolved Hide resolved
Comment on lines 483 to 489
order: 102,
tabIndex: 17,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are some high numbers... is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good call. I copied that from https://paellaplayer.upv.es/#/playground and forgot to adjust those numbers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tabIndex: 17 is still there? Or is that intentional now?

@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label May 16, 2024
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label May 30, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 May 30, 2024 16:51 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1163 June 3, 2024 11:22 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 1563c80 into elan-ev:master Jun 3, 2024
4 checks passed
@LukasKalbertodt
Copy link
Member

Quick note for everyone: due to how our test deployment works, existing videos will not have segments shown in our Tobira test deployments. Until the next Tobira release happens: then everything works as expected. Also: we can manually run a resync on the test deployment and sometimes we might do that, so it might work randomly. Don't let this confuse you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants