fix dual-stack ipv6 listening on windows, add listen addr option #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Repository owner
deleted a comment from
Proxtate
Dec 14, 2023
Repository owner
deleted a comment from
Proxtate
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to windows document, the sockets only operates over the IPv6 protocol by default, so we need to modify the socket before using it.
Also
--listen-addroption is added to be able to bind on a certain address, default is [::].Tested on win10 and linux.
Refs:
https://learn.microsoft.com/en-us/windows/win32/winsock/dual-stack-sockets
https://docs.rs/tokio/1.29.1/tokio/net/struct.TcpSocket.html
https://docs.rs/socket2/latest/socket2/struct.Socket.html#method.set_only_v6