Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create amd64 and arm64 Docker images #35

Merged
merged 5 commits into from Apr 5, 2020
Merged

Automatically create amd64 and arm64 Docker images #35

merged 5 commits into from Apr 5, 2020

Conversation

SShah7433
Copy link
Contributor

args: operating system (OS) and architecture (ARCH)

args: operating system (OS) and architecture (ARCH)
@SShah7433 SShah7433 closed this Apr 4, 2020
 Automatically build for amd64 and arm64
@SShah7433
Copy link
Contributor Author

Reopening with complete changes

@SShah7433 SShah7433 reopened this Apr 4, 2020
@SShah7433
Copy link
Contributor Author

@eko - As a note, docker hub credentials will have to be added to the repo for this to work.

Prevent travis build failure
@SShah7433
Copy link
Contributor Author

Would help provide remediation for #13

@SShah7433 SShah7433 changed the title Add build args Automatically create amd64 and arm64 Docker images Apr 4, 2020
@eko
Copy link
Owner

eko commented Apr 4, 2020

Hi @SShah7433,

Great, thanks, I added the DOCKER_USERNAME and DOCKER_PASSWORD secrets to the repository but it continues to fail when trying to push the image on the docker hub:

Successfully built 4584a8bc87f9
Successfully tagged ekofr/pihole-exporter:amd64
Successfully tagged ekofr/pihole-exporter:sha-0bcc3d8
Pushing image [ekofr/pihole-exporter:amd64 ekofr/pihole-exporter:sha-0bcc3d8]
The push refers to repository [docker.io/ekofr/pihole-exporter]
19f790e656cf: Preparing
0f990a9408a4: Preparing
denied: requested access to the resource is denied
Error: exit status 1
exit status 1

@SShah7433
Copy link
Contributor Author

@eko - Oddly enough, it completed successfully on my repo. Before I start dgging further, could you double check the credentials?

@eko
Copy link
Owner

eko commented Apr 5, 2020

Hi @SShah7433, I think I just understood why, when reading the settings page:

Secrets are not passed to workflows that are triggered by a pull request from a fork

I will merge this PR now to see if it's work on master branch ;)

Thank you!

@eko eko merged commit bd901d9 into eko:master Apr 5, 2020
@eko
Copy link
Owner

eko commented Apr 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants