Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type of the project #70

Merged
merged 1 commit into from Oct 9, 2018
Merged

Update type of the project #70

merged 1 commit into from Oct 9, 2018

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Oct 9, 2018

In order to be able to add a flex recipe, the bundles should set "type": "symfony-bundle": https://symfony.com/doc/current/bundles/best_practices.html#installation

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

In order to be able to add a flex recipe, the bundles should set `"type": "symfony-bundle"`: https://symfony.com/doc/current/bundles/best_practices.html#installation
@eko eko merged commit becbf60 into eko:master Oct 9, 2018
@eko
Copy link
Owner

eko commented Oct 9, 2018

Hello, good catch! Thank you @franmomu :)

@franmomu franmomu deleted the patch-1 branch October 9, 2018 13:00
@franmomu
Copy link
Contributor Author

franmomu commented Oct 9, 2018

You're welcome!

@franmomu
Copy link
Contributor Author

franmomu commented Oct 9, 2018

I've just created symfony/recipes-contrib#520, I tried it and apparently it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants