Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update For Symfony 4 ?? #64

Closed
wants to merge 6 commits into from
Closed

Update For Symfony 4 ?? #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5836791
Added support for Symfony4
devmax-pro Apr 21, 2018
7b65fdf
Update feed.xml
Muspi Apr 25, 2018
c44e91d
Update feed.xml
Muspi Apr 25, 2018
1cf8690
Update Composer
Muspi Apr 25, 2018
dc3c009
Update composer.json
Muspi Apr 25, 2018
468fe69
Fix error on config service feed
Muspi Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions Resources/config/feed.xml
View file
Open in desktop
Expand Up @@ -12,13 +12,13 @@
</parameters>

<services>
<service id="eko_feed.feed.manager" class="%eko_feed.feed.manager.class%">
<service id="eko_feed.feed.manager" class="%eko_feed.feed.manager.class%" public="true">
<argument type="service" id="router" />
<argument>%eko_feed.config%</argument>
<argument />
</service>

<service id="eko_feed.feed.dump" class="%eko_feed.feed.dump.class%">
<service id="eko_feed.feed.dump" class="%eko_feed.feed.dump.class%" public="true">
<argument type="service" id="eko_feed.feed.manager" />
<argument type="service" id="doctrine.orm.entity_manager" />
<argument type="service" id="filesystem" />
Expand All @@ -27,9 +27,9 @@
</call>
</service>

<service id="eko_feed.feed.reader" class="%eko_feed.feed.reader.class%" />
<service id="eko_feed.feed.reader" class="%eko_feed.feed.reader.class%" public="true" />

<service id="eko_feed.feed" class="%eko_feed.feed.class%">
<service id="eko_feed.feed" class="%eko_feed.feed.class%" public="true">
<argument />
<call method="setRouter">
<argument type="service" id="router" />
Expand Down
19 changes: 4 additions & 15 deletions composer.json
View file
Open in desktop
@@ -1,19 +1,13 @@
{
"name": "eko/feedbundle",
"name": "muspi/feedbundle",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep original bundle name here please? Also restore the authors section. Thank you.

"type": "library",
"description": "A Symfony bundle to build RSS feeds from entities",
"description": "A Symfony bundle to build RSS feeds from entities, clone from eko/feedbundle",
"keywords": ["feed", "bundle", "rss", "atom"],
"homepage": "http://github.com/eko/FeedBundle",
"license": "MIT",
"authors": [
{
"name": "Vincent Composieux",
"email": "vincent.composieux@gmail.com"
}
],
"license": "MIT",
"require": {
"php": "^5.4|^7.0",
"symfony/framework-bundle": "^2.5|^3.0",
"symfony/framework-bundle": "^2.5|^3.0|^4.0",
"zendframework/zend-feed": ">=2.0",
"zendframework/zend-servicemanager": ">=2.0",
"zendframework/zend-http": ">=2.0"
Expand All @@ -27,10 +21,5 @@
},
"autoload": {
"psr-4": { "Eko\\FeedBundle\\": "" }
},
"extra": {
"branch-alias": {
"dev-master": "1.1.x-dev"
}
}
}