New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small bugfix in roundPixels so it now also works smoothly with hires enabled #209

Open

stephanvermeire wants to merge 2 commits into ekelokorpi:master from stephanvermeire:master

Contributor

stephanvermeire commented Mar 21, 2019

Sprites now move really with one pixel at a time then roundPixels=true exabled.


          small bugfix in roundPixels so it now also works smoothly with hires …

719627a

…enabled

Owner

ekelokorpi commented Mar 27, 2019

Thanks for the PR! All pull requests should go to the develop branch: https://github.com/ekelokorpi/panda-engine/tree/develop

Could you explain your code changes a bit? I'm not sure if i understand it correctly.

For example this new line:
tx = Math.round(tx * game.scale)/game.scale;

Now if the game.scale value is 2, that line would not change the value at all, so it's doing the rounding for nothing?

Example:
Math.round(1.5 * 2) / 2 would result value 1.5


          Merge remote-tracking branch 'upstream/develop'

a36dfde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment