Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix devdeps #1075

Merged
merged 2 commits into from
Nov 21, 2023
Merged

TST: Fix devdeps #1075

merged 2 commits into from
Nov 21, 2023

Conversation

pllim
Copy link
Collaborator

@pllim pllim commented Nov 21, 2023

Fix devdeps job that is failing.

xref astropy/astropy#15638

@pllim pllim marked this pull request as ready for review November 21, 2023 19:58
@pllim pllim requested a review from ejeschke November 21, 2023 19:58
@pllim pllim added the maintenance Work done to keep code maintained label Nov 21, 2023
@pllim pllim added this to the 5.0 milestone Nov 21, 2023
@ejeschke
Copy link
Owner

Hmmm, they are deprecating datetime.datetime.utcfromtimestamp? Think I'm going to need to scour a few additional software projects...

Copy link
Owner

@ejeschke ejeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me @pllim. Thank you and FFTM!

@pllim pllim merged commit e9bbd26 into ejeschke:main Nov 21, 2023
9 checks passed
@pllim pllim deleted the fix-devdeps branch November 21, 2023 21:29
@pllim
Copy link
Collaborator Author

pllim commented Nov 21, 2023

Yup, utcnow is also deprecated in Python 3.12, see astropy/astropy#15298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Work done to keep code maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants