Change default value for maximum amount #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredjn
requested review from
t-persson and
andmat900
and removed request for
a team
By making the default value for maximum amount configurable both from the environment and the data det we can effectively controll wether the paralell-test feature in ETOS is opt-in or out, and at the same time give the test operator the ability to tailor it specifically to his/her need by setting the maxumum_amount parameter in the dataset.
t-persson
reviewed
May 17, 2024
Comment on lines
421
to
432
| # Check out and assign IUTs to test runners. | ||
| iuts = self.iut_provider.wait_for_and_checkout_iuts( | ||
| minimum_amount=1, | ||
| maximum_amount=self.dataset.get( | ||
| "maximum_amount", | ||
| os.getenv( | ||
| "ETOS_MAX_PARALLEL_IUTS", | ||
| self.etos.config.get("TOTAL_TEST_COUNT"), | ||
| ), | ||
| ) | ||
| self.splitter.assign_iuts(test_runners, iuts) | ||
| span.set_attribute(SemConvAttributes.IUT_DESCRIPTION, str(iuts)) | ||
| ), | ||
| ) | ||
| self.splitter.assign_iuts(test_runners, iuts) |
There was a problem hiding this comment.
Looks like you need to rebase? The traces have been removed
There was a problem hiding this comment.
I think it was a rebase conflict misstake on my part. Lates commit fixes it (I hope)
t-persson
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Make the default value for maximum amount configurable from the environment and the dataset. This allows for better control over the parallel-test feature in ETOS and gives the test operator the ability to tailor it specifically to their needs by setting the maximum_amount parameter in the dataset.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Fredrik Fristedt <fredrik.fristedt@axis.com>