use execa for better windows support
#40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
|
dooooh "Bad substitution" error on the CI :D i didn't have that problem, but yea.. I'm on ArchLinux. Probably should add again edit: but adding |
added 2 commits
June 6, 2018 23:39
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
| @@ -22,6 +22,7 @@ | |||
| "cac": "^5.0.10", | |||
| "chalk": "^2.4.1", | |||
| "cross-spawn": "^6.0.5", | |||
There was a problem hiding this comment.
Wanna take this out if it isn't being used anymore?
There was a problem hiding this comment.
oh yea, forgot about that.. thanks.
egoist
reviewed
Jun 7, 2018
| let script = null | ||
|
|
||
| if (isShell) { | ||
| script = [task.script, ...args] |
There was a problem hiding this comment.
hmm does this work? maid log hello world:
## log
```sh
echo $1;
echo $2;
```There was a problem hiding this comment.
probably yes. the readme scripts works, so. but not sure how to handle the windows yet ;/
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #22. Plus better handling of python and actually the shorthands for those "languages".
Sorry that it's in one big commit, it was impossible in another way.
The thing is the following: a) When bash, we don't pass
bashorshor-cto the the exec call, so it can be handled byexeca(i belive it switches between what's needed depending on platform?). b) If code block ispythonorpypasspython -cto the command call. c) otherwise just call whatever is the codeblock.The tests snapshots are intentionally updated, because was required too. We should trim the incoming code fence block content, because it may lead to errors in python for example.