[#1318] Fix leaking fragments #1319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some refactoring for listeners registering. Move listener holders from properties map to backing field by lazy() kotlin to reduce indent and lines.
|
Thank you for review @SKeeneCode The rootParentChangeListener instance is still hold by the property |
|
I think this looks good - could you apply this bugfix to the tornadofx2 repo and then I can modify the reference in the workspace (or you could do it). I actually think the way I went about fixing the bug was a poor way. I think instead of removing and re-adding the listener I can just do |
|
Hi @SKeeneCode, I've done what you're asking here: edvin/tornadofx2#40 |
edvin
added a commit
to edvin/tornadofx2
that referenced
this pull request
Aug 5, 2021
Backport edvin/tornadofx#1319 to Tornado2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix leaking Fragments.
Remove windowProperty() listener before undocking.
And some refactoring for listeners registering for dock/undock.
Move listener holders from properties (map) to backing field by lazy() kotlin to reduce indent and lines.
Even the fixes pass the test cases, I couldn't find a way to check memory leaking.
It should be verified manually using jmap histogram dump.
Please review the code.