Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Change Sidekiq queues to critical, default and low only. For efficiency #2518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gustavosobral
Copy link
Contributor

What

It creates three queues (critical, default, and low) and assign all the workers to it.

From Sidekiq documentation:

I don't recommend having more than a handful of queues. Lots of queues makes for a more complex system and Sidekiq Pro cannot reliably handle multiple queues without polling. M Sidekiq Pro processes polling N queues means O(M*N) operations per second slamming Redis.
https://github.com/mperham/sidekiq/wiki/Advanced-Options#queues

Closes #1381

@gustavosobral gustavosobral requested a review from a team as a code owner January 12, 2020 21:57
@ghost ghost requested a review from andrewbredow January 12, 2020 21:57
@andrewbredow andrewbredow requested review from JessRudder and removed request for andrewbredow January 14, 2020 19:32
@andrewbredow
Copy link
Contributor

@JessRudder Adding you as reviewer because I think this is moda-focused. Feel free to redirect if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Sidekiq queue efficiency
2 participants