Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[WIP] Upgrade to Rails 6.0.1 #2472

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[WIP] Upgrade to Rails 6.0.1 #2472

wants to merge 13 commits into from

Conversation

JessRudder
Copy link
Contributor

@JessRudder JessRudder commented Nov 19, 2019 •
edited

We're upgrading to Rails 6.0.1! 🎉

Here's what needs to be done:

  • Check changelogs for upgraded gems for any gotchas:
    • rails-i18n
    • sass-rails
    • sprockets (correct the quotes used here)
    • action-cable-testing
  • Make decision on encrpyted cookies
    • 6.0.1 has new encrypted cookies that are more secure but if we use them, all the 5.2.X cookies will be invalidated as soon as we upgrade
  • Check that npm packages are correctly moved into the rails scope where necessary
  • TBD

@JessRudder JessRudder added the WIP 💭 PR's that are a 'Work In Progress' label Nov 19, 2019
@JessRudder JessRudder requested a review from a team as a code owner November 19, 2019 01:38
@JessRudder JessRudder self-assigned this Nov 19, 2019
@JessRudder JessRudder added this to In progress in GitHub Classroom via automation Nov 19, 2019
@ghost ghost requested a review from renz45 November 19, 2019 01:38
@renz45
Copy link

renz45 commented Nov 19, 2019 •
edited

That ParameterFilter error is coming from rspec I believe, if you upgrade to gem 'rspec-rails', '>= 4.0.0.beta3' it should solve the issue.

I also didn't see any issues with sass/sprockets so far either 😄

@JessRudder JessRudder force-pushed the official-rails-6-0-1-upgrade branch 3 times, most recently from 392e01c to a01781b Compare November 22, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renz45 renz45 Awaiting requested review from renz45

Assignees

@JessRudder JessRudder

Labels
WIP 💭 PR's that are a 'Work In Progress'
Projects
GitHub Classroom
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JessRudder @renz45