Fetch GitHub Team name for Classroom Assistant

[srinjoym]

Fetch the team name from GitHub everytime we serialize a group assignment repo. This fixes education/classroom-assistant#117

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

[andrewbredow]

@srinjoym Is this still WIP? Should we close it?

[jeffrafter]

Small clarification but I love how simple this is ❇️

[jeffrafter]

I'm trying to understand the implications of fetching from the API here; If I am understanding correctly we fetch from the API every time we access the github_* properties. This means every time we serialize a GroupAssignmentRepo to JSON we will hit the github API. The main place this feels problematic is here:

classroom/app/controllers/api/group_assignment_repos_controller.rb

Lines 11 to 12 in 8be229a

	repos = GroupAssignmentRepo.where(group_assignment: @group_assignment).order(:id)
	paginate json: repos

This introduces and github API N+1 if I am reading this right. I'm not clear if that is acceptable.

[andrewbredow]

Depending on our setup, I think OctoKit would cache these at the client level?

[d12]

Octokit should cache them, correct