Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract optional and required SGX claims provided by Open Enclave #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

THS-on
Copy link

@THS-on THS-on commented Nov 17, 2023

This change implements the extraction of all the optional and required SGX claims provided by Open Enclave.
The main motivation was to get the UEID which matches the QEID, so that it is possible to tie the quote and machine where the enclave is running on together. The additional information gives more flexibility to attest the system.

Changes around the Report struct:

  • Added UEID field which is QEID for SGX
  • Added SGXClaims field which holds the optional and required claims
  • Added conversion functions between internal and attestation structs. What is the reason behind the duplication of those structs?

Two new structs SGXOptional and SGXRequired are introduced to hold the respective claims.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for ego-docs ready!

Name Link
🔨 Latest commit 09943de
🔍 Latest deploy log https://app.netlify.com/sites/ego-docs/deploys/65574e94ce35180008e686e9
😎 Deploy Preview https://deploy-preview-233--ego-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thomasten
Copy link
Member

Thank you for wanting to contribute to EGo! The feature makes sense and we would like to accept it. I haven't reviewed the implementation in detail yet. You need to sign the CLA (see above) so that we can accept your contribution.

@THS-on
Copy link
Author

THS-on commented Nov 17, 2023

I need to check, if I can sign the CLA. This might take longer time. Is it possible to contribute changes without the CLA?

@thomasten
Copy link
Member

No, unfortunately not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants